Skip to content

bugfix(gamelod): Disable the recommended static lod level for texture reduction to prevent low texture resolution with 'Medium' and 'High' specs #1630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 12, 2025
Merged

bugfix(gamelod): Disable the recommended static lod level for texture reduction to prevent low texture resolution with 'Medium' and 'High' specs #1630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
451460e
tweak(gamelod): Simplify game detail setup for options menu
xezon Sep 24, 2025
eb881bc
feat(gamelod): Implement 'Very High' system spec
xezon Sep 24, 2025
1364e1f
bugfix(gamelod): Disable the recommended static lod level for texture…
xezon Sep 24, 2025
285ed43
Replicate in Generals
xezon Oct 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Generals/Code/GameEngine/Include/Common/GameLOD.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,7 @@ class GameLODManager
void applyStaticLODLevel(StaticGameLODLevel level);
void applyDynamicLODLevel(DynamicGameLODLevel level);
void refreshCustomStaticLODLevel(void); ///<grabs current globaldata values and makes them the custom detail setting.
StaticGameLODLevel getRecommendedTextureLODLevel();

static const FieldParse m_staticGameLODFieldParseTable[];
StaticGameLODLevel m_currentStaticLOD; ///< current value of static LOD.
Expand Down
53 changes: 40 additions & 13 deletions Generals/Code/GameEngine/Source/Common/GameLOD.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,16 +555,23 @@ void GameLODManager::applyStaticLODLevel(StaticGameLODLevel level)
StaticGameLODInfo *lodInfo=&m_staticGameLODInfo[level];
StaticGameLODInfo *prevLodInfo=&prevLodBackup;

Int requestedTextureReduction = 0;
Bool requestedTrees = m_memPassed; //only use trees if memory requirement passed.
Int requestedTextureReduction;
Bool requestedTrees;
if (level == STATIC_GAME_LOD_CUSTOM)
{ requestedTextureReduction = lodInfo->m_textureReduction;
{
requestedTextureReduction = lodInfo->m_textureReduction;
requestedTrees = lodInfo->m_useTrees;
}
else
if (level >= STATIC_GAME_LOD_LOW)
{ //normal non-custom level gets texture reduction based on recommendation
requestedTextureReduction = getRecommendedTextureReduction();
{
//normal non-custom level gets texture reduction based on recommendation
StaticGameLODLevel textureLevel = getRecommendedTextureLODLevel();
if (textureLevel == STATIC_GAME_LOD_UNKNOWN)
textureLevel = level;
requestedTextureReduction = getLevelTextureReduction(textureLevel);

//only use trees if memory requirement passed.
requestedTrees = m_memPassed;
}

if (TheGlobalData)
Expand Down Expand Up @@ -717,16 +724,36 @@ void GameLODManager::applyDynamicLODLevel(DynamicGameLODLevel level)

Int GameLODManager::getRecommendedTextureReduction(void)
{
if (m_idealDetailLevel == STATIC_GAME_LOD_UNKNOWN)
getRecommendedStaticLODLevel(); //it was never tested, so test now.
StaticGameLODLevel level = getRecommendedTextureLODLevel();

if (level == STATIC_GAME_LOD_UNKNOWN)
{
level = getStaticLODLevel();
}
return getLevelTextureReduction(level);
}

if (!m_memPassed) //if they have < 256 MB, force them to low res textures.
return getLevelTextureReduction(STATIC_GAME_LOD_LOW);
StaticGameLODLevel GameLODManager::getRecommendedTextureLODLevel()
{
// TheSuperHackers @bugfix xezon 24/09/2025 Disables the recommended static LOD level for texture reduction
// because the benchmark code always generates a low level for it. Can revisit if the benchmarking is changed.
constexpr const Bool UseRecommendedStaticLODLevel = FALSE;

if (m_idealDetailLevel < 0 || m_idealDetailLevel >= STATIC_GAME_LOD_COUNT)
return getLevelTextureReduction(STATIC_GAME_LOD_LOW);
StaticGameLODLevel level = STATIC_GAME_LOD_LOW;

return getLevelTextureReduction(m_idealDetailLevel);
// Force low res textures if user has less than 256 MB.
if (m_memPassed)
{
if constexpr (UseRecommendedStaticLODLevel)
{
level = getRecommendedStaticLODLevel();
}
else
{
level = STATIC_GAME_LOD_UNKNOWN;
}
}
return level;
}

Int GameLODManager::getLevelTextureReduction(StaticGameLODLevel level)
Expand Down
1 change: 1 addition & 0 deletions GeneralsMD/Code/GameEngine/Include/Common/GameLOD.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,7 @@ class GameLODManager
void applyStaticLODLevel(StaticGameLODLevel level);
void applyDynamicLODLevel(DynamicGameLODLevel level);
void refreshCustomStaticLODLevel(void); ///<grabs current globaldata values and makes them the custom detail setting.
StaticGameLODLevel getRecommendedTextureLODLevel();

static const FieldParse m_staticGameLODFieldParseTable[];
StaticGameLODLevel m_currentStaticLOD; ///< current value of static LOD.
Expand Down
53 changes: 40 additions & 13 deletions GeneralsMD/Code/GameEngine/Source/Common/GameLOD.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,16 +560,23 @@ void GameLODManager::applyStaticLODLevel(StaticGameLODLevel level)
StaticGameLODInfo *lodInfo=&m_staticGameLODInfo[level];
StaticGameLODInfo *prevLodInfo=&prevLodBackup;

Int requestedTextureReduction = 0;
Bool requestedTrees = m_memPassed; //only use trees if memory requirement passed.
Int requestedTextureReduction;
Bool requestedTrees;
if (level == STATIC_GAME_LOD_CUSTOM)
{ requestedTextureReduction = lodInfo->m_textureReduction;
{
requestedTextureReduction = lodInfo->m_textureReduction;
requestedTrees = lodInfo->m_useTrees;
}
else
if (level >= STATIC_GAME_LOD_LOW)
{ //normal non-custom level gets texture reduction based on recommendation
requestedTextureReduction = getRecommendedTextureReduction();
{
//normal non-custom level gets texture reduction based on recommendation
StaticGameLODLevel textureLevel = getRecommendedTextureLODLevel();
if (textureLevel == STATIC_GAME_LOD_UNKNOWN)
textureLevel = level;
requestedTextureReduction = getLevelTextureReduction(textureLevel);

//only use trees if memory requirement passed.
requestedTrees = m_memPassed;
}

if (TheGlobalData)
Expand Down Expand Up @@ -723,16 +730,36 @@ void GameLODManager::applyDynamicLODLevel(DynamicGameLODLevel level)

Int GameLODManager::getRecommendedTextureReduction(void)
{
if (m_idealDetailLevel == STATIC_GAME_LOD_UNKNOWN)
getRecommendedStaticLODLevel(); //it was never tested, so test now.
StaticGameLODLevel level = getRecommendedTextureLODLevel();

if (level == STATIC_GAME_LOD_UNKNOWN)
{
level = getStaticLODLevel();
}
return getLevelTextureReduction(level);
}

if (!m_memPassed) //if they have < 256 MB, force them to low res textures.
return getLevelTextureReduction(STATIC_GAME_LOD_LOW);
StaticGameLODLevel GameLODManager::getRecommendedTextureLODLevel()
{
// TheSuperHackers @bugfix xezon 24/09/2025 Disables the recommended static LOD level for texture reduction
// because the benchmark code always generates a low level for it. Can revisit if the benchmarking is changed.
constexpr const Bool UseRecommendedStaticLODLevel = FALSE;

if (m_idealDetailLevel < 0 || m_idealDetailLevel >= STATIC_GAME_LOD_COUNT)
return getLevelTextureReduction(STATIC_GAME_LOD_LOW);
StaticGameLODLevel level = STATIC_GAME_LOD_LOW;

return getLevelTextureReduction(m_idealDetailLevel);
// Force low res textures if user has less than 256 MB.
if (m_memPassed)
{
if constexpr (UseRecommendedStaticLODLevel)
{
level = getRecommendedStaticLODLevel();
}
else
{
level = STATIC_GAME_LOD_UNKNOWN;
}
}
return level;
}

Int GameLODManager::getLevelTextureReduction(StaticGameLODLevel level)
Expand Down
Loading