[WIP] Add TLS endpoint

[joelanders]

Ok, I think this is all working.
Be careful to hit the endpoint with an explicit https, eg: https://localhost:whatever as I wasted a bit of time on this :p

[coveralls]

Coverage decreased (-0.05%) to 61.779% when pulling 894075c on feature/https_endpoint into 0c89c56 on master.

[coveralls]

Coverage decreased (-0.3%) to 61.162% when pulling e268de2 on feature/https_endpoint into 6f1eb71 on master.

[coveralls]

Coverage decreased (-0.2%) to 61.223% when pulling 8ef4dc3 on feature/https_endpoint into 6f1eb71 on master.

[hellais]

It would be ideal if we could keep backward compatibility with old configuration files.

I am thinking that instead of having the endpoints be a list we could expand them to something like:

bouncer_tls_port: XXX
bouncer_tls_cert: XXX
bouncer_hsdir: XXX

collector_tls_port: XXX
collector_tls_cert: XXX
etc.

[joelanders]

I kinda thought it was nicer to group all the needed things into an object. It'd be even nicer if I made that object the Twister ServerFromString or whatever.

[hellais]

Ok, let's keep this as is for the moment. I noticed you also added backward compatible changes so I think it's ok for the moment.

[hellais]

Overall this looks good 👍 I made a bit of comments for things that should be changed before we can merge this. Good stuff.

[coveralls]

Coverage decreased (-0.2%) to 61.261% when pulling 5fa24c3 on feature/https_endpoint into 6f1eb71 on master.

[coveralls]

Coverage decreased (-0.2%) to 61.237% when pulling 2fa2848 on feature/https_endpoint into 6f1eb71 on master.

[hellais]

I am going to move this into the scripts directory when merging.

[hellais]

Other things to take into consideration:

• If config.main.tor_hidden_service is set to false, then calls to getHSEndpoint will fail due to torconfig not being defined
• Make sure the documentation is updated to reflect the changes in the configuration file
• Update ooni-sysadmin to reflect the changes in this repo

[coveralls]

Coverage decreased (-0.3%) to 61.125% when pulling 35ccea7 on feature/https_endpoint into 6f1eb71 on master.

[hellais]

I created two tickets for the documentation/sysadmin tasks here:

• Update scripts for installing ooni-backend with SSL support sysadmin#49
• Add documentation on how to configured ooni-backend #72

I am going to to a final review of this branch and merge it.

[coveralls]

Coverage decreased (-0.3%) to 61.125% when pulling d7f9a4c on feature/https_endpoint into 6f1eb71 on master.

[hellais]

Now there is an issue with the fact that if you set tor_hidden_service: false and don't set the bouncer_endpoints or collector_endpoints to be a list (because for example you want to just run test helpers and not have a bouncer or a collector) it will try to iterate over a None-type:

    for endpoint_config in config.main.bouncer_endpoints:
TypeError: 'NoneType' object is not iterable

[hellais]

I fixed the outstanding bugs and merged into master.

Thanks!