Make CMock_Verify() available as UnityRunner_Verify() #455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having UnityRunner_Verify() accessible from within tests is useful for verifying the call chain halfway through a longer, integration-style test.
|
I'm not understanding what this is providing that we didn't already have with |
|
Sometimes it's useful to be able to verify that all the Expects have been fulfilled, without completely resetting the test. resetTest(), among other things, calls setUp() again, which may clear out important data that's needed in the remainder of the test. How about just renaming CMock_Verify() to verifyCalls() or something like that? And then adding prototypes for resetTest() and verifyCalls() in unity.h? I don't think CMock_Init() and CMock_Destroy() are that useful on their own, so they probably don't need to be made public. |
|
Added verifyTest in separate commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having UnityRunner_Verify() accessible from within tests is useful for verifying the call chain halfway through a longer, integration-style test.
This PR is basically equivalent to #376, only rebased on #454 and minimized.