Skip to content

Conversation

zcsahok
Copy link
Member

@zcsahok zcsahok commented Sep 18, 2025

Follow-up to #480: setting of serial speed for non-serial rigs fails due to internal checks in Hamlib function.

Rig model number is 2
Rig speed is 2400
Trying to start rig control
Speed not accepted!

Previously (when using low-level direct field setting) the value was simply unused and ignored. (2400 is the default speed in TLF)

The fix checks if we have a serial rig before setting the speed.
Inspired by Hamlib's src/conf.c:

...
    case TOK_SERIAL_SPEED:
        if (rp->type.rig != RIG_PORT_SERIAL)
        {
            return -RIG_EINVAL;
        }
...

@zcsahok zcsahok merged commit c345e04 into Tlf:master Sep 19, 2025
2 checks passed
@zcsahok zcsahok deleted the fix_setting_rig_speed branch September 19, 2025 19:46
@dl1jbe dl1jbe mentioned this pull request Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants