Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: Shorten town names in the occupied foreign and home towns list #413

Closed
galacticwarrior9 opened this issue Nov 26, 2021 · 0 comments · Fixed by #414
Closed

Suggestion: Shorten town names in the occupied foreign and home towns list #413

galacticwarrior9 opened this issue Nov 26, 2021 · 0 comments · Fixed by #414
Labels
enhancement New feature or request
Milestone
0.6.6

Comments

@galacticwarrior9
Copy link
Contributor

galacticwarrior9 commented Nov 26, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.
When a town has many occupied foreign towns, the list can take up much of the chat window:

Screenshot

The same problem applies to the occupied home towns list.

Describe the solution you'd like
Long-form town names should not be used after a certain number of occupied towns. Alternatively, adapt Towny's solution for displaying the list of towns in a nation (adding a hover-over button that displays the full list of towns when clicked).

Describe alternatives you've considered
N/A

Additional context
N/A
@galacticwarrior9 galacticwarrior9 added the enhancement New feature or request label Nov 26, 2021
@LlmDl LlmDl added this to the 0.6.6 milestone Nov 26, 2021
@galacticwarrior9 galacticwarrior9 changed the title Suggestion: Shorten town names in the occupied foreign towns list Suggestion: Shorten town names in the occupied foreign and home towns list Nov 26, 2021
LlmDl added a commit that referenced this issue Nov 26, 2021
@LlmDl
Make SiegeWar use newer StatusScreen objects.
9bdc1a7 
- SiegeWar now uses the StatusScreen objects to add details to Towny
status screens.
- Includes:
  - Nation Refund, Plunder, Military Salary details are now
click-to-collect from the Resident Status Screen.
  - Town status screen moves many Siege details to [Sieged] hoverable
component.
  - Nation status screen only shows lists when they are greater than
zero.
  - Lists of Towns in the Nation status screens will now condense to
shorter, un-formatted names when the lists are longer than 20.
    - Partially completes #413.
LlmDl added a commit that referenced this issue Nov 27, 2021
@LlmDl
Add commands:
c5e50d2 
/nation siegewar occupiedhometowns
/nation siegewar occupiedforeigntowns

Made /n screens show only 10 occupied towns per list, with the option to
click the screen to run the above commands and see the full lists.

Closes #413.
@LlmDl LlmDl mentioned this issue Nov 27, 2021
Merged
1 task
LlmDl added a commit that referenced this issue Nov 29, 2021
@LlmDl
Use Towny's new StatusScreen components. (#414)
6a0d902 
* Make SiegeWar use newer StatusScreen objects.

- SiegeWar now uses the StatusScreen objects to add details to Towny
status screens.
- Includes:
  - Nation Refund, Plunder, Military Salary details are now
click-to-collect from the Resident Status Screen.
  - Town status screen moves many Siege details to [Sieged] hoverable
component.
  - Nation status screen only shows lists when they are greater than
zero.
  - Lists of Towns in the Nation status screens will now condense to
shorter, un-formatted names when the lists are longer than 20.
    - Partially completes #413.

* Minor tweaks and comments

* Add commands:

/nation siegewar occupiedhometowns
/nation siegewar occupiedforeigntowns

Made /n screens show only 10 occupied towns per list, with the option to
click the screen to run the above commands and see the full lists.

Closes #413.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.6.6
Development

Successfully merging a pull request may close this issue.

Use Towny's new StatusScreen components. TownyAdvanced/SiegeWar
2 participants
@LlmDl @galacticwarrior9