Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Towny's new StatusScreen components. #414

Merged
merged 3 commits into from
Nov 29, 2021
Merged

Conversation

LlmDl
Copy link
Member

@LlmDl LlmDl commented Nov 27, 2021

Description:

  • SiegeWar now uses the StatusScreen objects to add details to Towny
    status screens.
  • Includes:
    • Nation Refund, Plunder, Military Salary details are now
      click-to-collect from the Resident Status Screen.
    • Town status screen moves many Siege details to [Sieged] hoverable
      component.
    • Nation status screen only shows lists when they are greater than
      zero.
      • Made /n screens show only 10 occupied towns per list, with the option to
        click the screen to run the above commands and see the full lists.

New Nodes/Commands/ConfigOptions:

/nation siegewar occupiedhometowns {nationname}
/nation siegewar occupiedforeigntowns {nationname}

Shows full lists of occupied towns.


Relevant Issue ticket:

Closes #413


  • I have tested this pull request for defects on a server.

By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the SiegeWar License for perpetuity.

- SiegeWar now uses the StatusScreen objects to add details to Towny
status screens.
- Includes:
  - Nation Refund, Plunder, Military Salary details are now
click-to-collect from the Resident Status Screen.
  - Town status screen moves many Siege details to [Sieged] hoverable
component.
  - Nation status screen only shows lists when they are greater than
zero.
  - Lists of Towns in the Nation status screens will now condense to
shorter, un-formatted names when the lists are longer than 20.
    - Partially completes #413.
/nation siegewar occupiedhometowns
/nation siegewar occupiedforeigntowns

Made /n screens show only 10 occupied towns per list, with the option to
click the screen to run the above commands and see the full lists.

Closes #413.
@LlmDl LlmDl self-assigned this Nov 27, 2021
@LlmDl LlmDl added this to the 0.6.6 milestone Nov 27, 2021
@LlmDl LlmDl merged commit 6a0d902 into master Nov 29, 2021
@LlmDl LlmDl deleted the feature/status_components branch November 29, 2021 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: Shorten town names in the occupied foreign and home towns list
1 participant