Merge pull request #87 from TransactionProcessing/task/#84_merchantbalanceprojection

Handle events from invalid merchant

Author: StuartFerguson

EventStoreProjections/test/MerchantBalanceProjectionTests.js

@@ -233,6 +233,94 @@ describe('Merchant Balance Projection Tests', function () {
         chai.expect(merchant.balance).equal(initialBalance);
     })
 
+    it('Merchant doesnt exist', function(){
+        projection.initialize();
+
+        var estateId = '3bf2dab2-86d6-44e3-bcf8-51bec65cf8bc';
+        var merchantId = 'c4c33d75-f011-40e4-9d97-1f428ab563d8';
+
+        var depositDateTime = '2020-05-30T06:21:31.356Z';
+        var depositAmount = 1000.00;
+        var manualDepositMadeEvent =
+            testData.getManualDepositMadeEvent(estateId, merchantId, depositDateTime, depositAmount);
+
+        projection.processEvent("MerchantDepositListAggregate-c4c33d75-f011-40e4-9d97-1f428ab563d8", 
+        manualDepositMadeEvent.eventType,
+        manualDepositMadeEvent.data
+        );
+      
+        var projectionState = projection.getState();
+
+        var merchant = projectionState.merchant;
+        chai.expect(merchant).equal(null);    
+
+        var depositDateTime = '2020-05-30T06:21:31.356Z';
+        var depositAmount = 1000.00;
+        var automaticDepositMadeEvent =
+            testData.getAutomaticDepositMadeEvent(estateId, merchantId, depositDateTime, depositAmount);
+
+        projection.processEvent("MerchantDepositListAggregate-c4c33d75-f011-40e4-9d97-1f428ab563d8", 
+        automaticDepositMadeEvent.eventType,
+        automaticDepositMadeEvent.data
+        );
+      
+        var projectionState = projection.getState();
+
+        var merchant = projectionState.merchant;
+        chai.expect(merchant).equal(null);    
+      
+        var transactionId = 'c4c33d75-f011-40e4-9d97-1f428ab563d8';
+        var transactionAmount = 10.00;
+        var transactionCompletedDateTime = '2023-11-01'
+        var transactionHasBeenCompletedEvent =
+            testData.getTransactionHasBeenCompletedEvent(estateId, merchantId, transactionId, true, transactionAmount, transactionCompletedDateTime); 
+
+        projection.processEvent("TransactionAggregate-c4c33d75-f011-40e4-9d97-1f428ab563d8", 
+        transactionHasBeenCompletedEvent.eventType,
+        transactionHasBeenCompletedEvent.data
+            );
+
+        var projectionState = projection.getState();
+
+        var merchant = projectionState.merchant;
+        chai.expect(merchant).equal(null);    
+
+        var transactionId = 'c4c33d75-f011-40e4-9d97-1f428ab563d8';
+        var calculatedValue = 5.00;
+        var eventCreatedDateTime = "2020-05-16T07:47:51.6617562+00:00";
+        var settledMerchantFeeAddedToTransactionEvent = testData.getSettledMerchantFeeAddedToTransactionEvent(estateId,
+            merchantId,
+            transactionId,
+            calculatedValue,
+            eventCreatedDateTime);
+
+        projection.processEvent(
+                'TransactionAggregate-c4c33d75-f011-40e4-9d97-1f428ab563d8',
+                settledMerchantFeeAddedToTransactionEvent.eventType,
+                settledMerchantFeeAddedToTransactionEvent.data);      
+
+        var projectionState = projection.getState();
+
+        var merchant = projectionState.merchant;
+        chai.expect(merchant).equal(null);    
+
+        var withdrawalDateTime = "2020-05-16T07:47:51.6617562+00:00";
+        var withdrawalAmount= 50.00;
+
+        var withdrawalMadeEvent =
+            testData.getWithdrawalMadeEvent(estateId, merchantId, withdrawalDateTime, withdrawalAmount);
+
+        projection.processEvent(
+                'MerchantAggregate-c4c33d75-f011-40e4-9d97-1f428ab563d8',
+                withdrawalMadeEvent.eventType,
+                withdrawalMadeEvent.data);  
+
+        var projectionState = projection.getState();
+
+        var merchant = projectionState.merchant;
+        chai.expect(merchant).equal(null);    
+    })
+
     it('Settled Merchant Fee increments balance', function(){
         projection.initialize();
 

EventStoreProjections/test/TestData.js

@@ -346,22 +346,30 @@ module.exports = {
 
     getTransactionHasBeenCompletedEvent: function (estateId, merchantId, transactionId, isAuthorised, transactionAmount, completedDateTime)
     {
-        return {
+        var event = 
+        {
             eventType: 'TransactionHasBeenCompletedEvent',
             data: {
                 "completedDateTime": completedDateTime,
-                "estateId": estateId,
-                "isAuthorised": isAuthorised,
+                "estateId": estateId,                
                 "transactionAmount": transactionAmount,
-                "merchantId": merchantId,
-                "responseCode": "0000",
-                "responseMessage": "SUCCESS",
+                "merchantId": merchantId,     
+                "responseCode": '1001',
+                "responseMessage": 'DECLINED',           
                 "transactionId": transactionId
             },
             metadata: {
             },
             eventId:"7F1FA1B5-449F-4F94-AF5C-5A536CBDAF57"
         }
+
+        if (isAuthorised){
+            event.data.isAuthorised = true;
+            event.data.responseCode = "0000";
+            event.data.responseMessage = "SUCCESS";
+        };
+        
+        return event;
     },
 
     getSettledMerchantFeeAddedToTransactionEvent: function (estateId, merchantId, transactionId, calculatedValue, feeEventCreatedDateTime)

NugetPackage/projections/continuous/MerchantBalanceProjection.js

@@ -39,15 +39,23 @@ function createMerchantState(merchantId, merchantName){
     return merchant;
 }
 
-function HandleMerchantCreatedEvent(s,e){
-    //var merchant = findMerchantInState(s,e.data.merchantId);
+function isMerchantValid(s){
+    if (s.merchant === null){
+       return false;     
+    }
+    return true;
+}
+
+function HandleMerchantCreatedEvent(s,e){    
     if (s.merchant === null){
         var newMerchantState = createMerchantState(e.data.merchantId, e.data.merchantName);        
         s.merchant = newMerchantState;
     }    
 }
 
 function HandleDepositEvent(s,e){   
+    if (isMerchantValid(s) == false)
+        return;
     s.merchant.balance += e.data.amount;
     s.merchant.numberOfEventsProcessed++;
     s.merchant.deposits.count++;
@@ -56,6 +64,8 @@ function HandleDepositEvent(s,e){
 }
 
 function HandleWithdrawalMadeEvent(s,e){
+    if (isMerchantValid(s) == false)
+        return;
     s.merchant.balance -= e.data.amount;
     s.merchant.numberOfEventsProcessed++;
     s.merchant.withdrawals.count++;
@@ -64,6 +74,9 @@ function HandleWithdrawalMadeEvent(s,e){
 }
 
 function HandleTransactionHasBeenCompletedEvent(s,e){   
+    if (isMerchantValid(s) == false)
+        return;
+
     s.merchant.numberOfEventsProcessed++;
 
     // Filter out logons and reconciliations
@@ -83,6 +96,9 @@ function HandleTransactionHasBeenCompletedEvent(s,e){
 }
 
 function HandleSettledMerchantFeeAddedToTransactionEvent(s,e){   
+    if (isMerchantValid(s) == false)
+        return;
+    
     s.merchant.numberOfEventsProcessed++;    
     s.merchant.balance += e.data.calculatedValue;
     s.merchant.fees.count++;