Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newsletter email design customization #12355

Closed
4 tasks done
rishabhgrg opened this issue Nov 10, 2020 · 0 comments
Closed
4 tasks done

Add newsletter email design customization #12355

rishabhgrg opened this issue Nov 10, 2020 · 0 comments
Assignees

Comments

@rishabhgrg
Copy link
Contributor

rishabhgrg commented Nov 10, 2020

Current newsletter email template design is not exactly customisable, and site owners want to change the header, and add copyright, address, or legal information in the footer.

Design customisation for newsletters allows site owners to make the email template work for them without needing to resort to fully custom template.

  • Allow Show/Hide Site title/logo Header
  • Allow Serif/Sans Serif Typography in email body
  • Allow custom Footer text with links
  • Allow Show/Hide "Publish with Ghost" badge, with hide by default.
rishabhgrg pushed a commit to rishabhgrg/Ghost that referenced this issue Nov 10, 2020
refs TryGhost#12355

This copies over existing emailTemplate config to ensure that updating
to use the settings will keep existing functionality for sites.
rishabhgrg added a commit to rishabhgrg/Ghost that referenced this issue Nov 10, 2020
refs TryGhost#12355

- Adds migration for updating group for new newsletter settings
rishabhgrg added a commit to rishabhgrg/Ghost that referenced this issue Nov 10, 2020
refs TryGhost#12355

Adds new default settings for newsletter design
rishabhgrg pushed a commit to rishabhgrg/Ghost that referenced this issue Nov 10, 2020
refs TryGhost#12355

- Passes newsletter settings to template
- Updates template to update design based on settings
rishabhgrg pushed a commit that referenced this issue Nov 11, 2020
refs #12355

- Adds new default settings for newsletter customisations - `newsletter_show_badge`, `newsletter_show_header` and `newsletter_body_font_category`
- Adds migrations to update group for new settings
- Add migration to update settings based on existing config value for newsletter settings
- Passes new newsletter settings to newsletter template and updates design based on them
- Fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants