Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Published post actions wrap over "add feature image" #18690

Closed
1 task done
lorumic opened this issue Oct 18, 2023 · 1 comment
Closed
1 task done

Published post actions wrap over "add feature image" #18690

lorumic opened this issue Oct 18, 2023 · 1 comment
Assignees
Labels
affects:admin Anything relating to Ghost Admin affects:editor Work relating to the Koenig Editor design stale [triage] Issues that were closed to to lack of traction

Comments

@lorumic
Copy link

lorumic commented Oct 18, 2023

Issue Summary

I experienced this issue on an old Android phone - so kind of an edge case - and I was able to reproduce it easily in the device view of the Chrome dev tools.
The problem is: when editing a published post on mobile, if there is not enough space in the header, the 2 Update/Unpublish action buttons at the top wrap to a second line, due to the flex-wrap attribute of their parent, and cover the "Add feature image" button, making it unusable:

Peek 2023-10-18 15-31

I guess this might also be the reason why, for a draft post, display: none is applied to the "Preview" button when screen width is less than or equal to 500px. I don't know if a similar solution would be good in this case, though, as they might both be important, so we might not want to hide either of them. However, being able to add the feature image to a published post is important too, so hopefully a reasonable solution can be found - or maybe none at all, if it's indeed too much of an edge case.

Steps to Reproduce

  1. Open Chrome dev tools, toggle device mode.
  2. Select "Dimensions: Responsive" to dynamically resize the device width.
  3. Lower the width until you see the problem: the 2 action buttons wrap to a second line and cover the upper part of the editor, where the "Add feature image" button is placed.

Ghost Version

5.69.3

Node.js Version

v18.18.2

How did you install Ghost?

From source (Ubuntu)

Database type

MySQL 5.7

Browser & OS version

Google Chrome 118.0.5993.70, Ubuntu

Relevant log / error output

No response

Code of Conduct

  • I agree to be friendly and polite to people in this repository
@github-actions github-actions bot added the needs:triage [triage] this needs to be triaged by the Ghost team label Oct 18, 2023
@daniellockyer daniellockyer added affects:editor Work relating to the Koenig Editor affects:admin Anything relating to Ghost Admin design and removed needs:triage [triage] this needs to be triaged by the Ghost team labels Nov 8, 2023
lorumic added a commit to lorumic/Ghost that referenced this issue Nov 21, 2023
fixes 18690
This change makes the headers for post editor main section and post
settings side panel use sticky position instead of absolute/fixed
respectively. This allows to solve the following 2 problems:
1. The published post actions wrapping over the "Add feature image"
button (issue TryGhost#18690).
2. The header of the post settings section having incorrect width, and
causing the underlying content to be visible on the right edge.
@sanne-san sanne-san self-assigned this Dec 4, 2023
Copy link
Contributor

github-actions bot commented Apr 2, 2024

Our bot has automatically marked this issue as stale because there has not been any activity here in some time.

The issue will be closed soon if there are no further updates, however we ask that you do not post comments to keep the issue open if you are not actively working on a PR.

We keep the issue list minimal so we can keep focus on the most pressing issues. Closed issues can always be reopened if a new contributor is found. Thank you for understanding 🙂

@github-actions github-actions bot added the stale [triage] Issues that were closed to to lack of traction label Apr 2, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects:admin Anything relating to Ghost Admin affects:editor Work relating to the Koenig Editor design stale [triage] Issues that were closed to to lack of traction
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants