Skip to content

Added more language support to wordCount #9509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2018
Merged

Added more language support to wordCount #9509

merged 1 commit into from
Mar 22, 2018

Conversation

rkalis
Copy link
Contributor

@rkalis rkalis commented Mar 16, 2018

closes #9507

  • Changed the utils.wordCount implementation to the one used by simpleMDE
  • Added extra À-ÿ to the regex to support diacritics characters
  • Added corresponding text with Chinese text mentioned in the issue

closes #9507
- Changed the utils.wordCount implementation to the one used by simpleMDE
- Added extra À-ÿ to the regex to support diacritics characters
- Added corresponding text with Chinese text mentioned in the issue
@kirrg001 kirrg001 self-assigned this Mar 16, 2018
Copy link
Contributor

@kirrg001 kirrg001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works good. I've tested some production articles from a known blog.

@AileenCGN Anything you would like to test?
Otherwise feel free to merge 👍

@aileen
Copy link
Member

aileen commented Mar 22, 2018

LGTM 👍

@aileen aileen merged commit 4013023 into TryGhost:master Mar 22, 2018
@xiaochunjimmy
Copy link

Nice work~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reading_time helper doesn't work with Chinese
4 participants