New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more language support to wordCount #9509

Merged
merged 1 commit into from Mar 22, 2018

Conversation

Projects
None yet
4 participants
@rkalis
Contributor

rkalis commented Mar 16, 2018

closes #9507

  • Changed the utils.wordCount implementation to the one used by simpleMDE
  • Added extra À-ÿ to the regex to support diacritics characters
  • Added corresponding text with Chinese text mentioned in the issue
Added more language support to wordCount
closes #9507
- Changed the utils.wordCount implementation to the one used by simpleMDE
- Added extra À-ÿ to the regex to support diacritics characters
- Added corresponding text with Chinese text mentioned in the issue

@kirrg001 kirrg001 self-assigned this Mar 16, 2018

@kirrg001

This works good. I've tested some production articles from a known blog.

@AileenCGN Anything you would like to test?
Otherwise feel free to merge 👍

@AileenCGN

This comment has been minimized.

Member

AileenCGN commented Mar 22, 2018

LGTM 👍

@AileenCGN AileenCGN merged commit 4013023 into TryGhost:master Mar 22, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@xiaochunjimmy

This comment has been minimized.

xiaochunjimmy commented Mar 28, 2018

Nice work~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment