Skip to content
This repository was archived by the owner on Aug 15, 2024. It is now read-only.

Conversation

bermudezmt
Copy link
Contributor

@sarahcstringer
Copy link
Contributor

LGTM.
Just noticing that I see some other places where this mistake might be happening:

❯ grep -r "use Twilio" . | grep Twiml
./voice/queueing/agent/queue-agent.5.x.php:use Twilio\Twiml\VoiceResponse;
./voice/queueing/caller/queue-caller.5.x.php:use Twilio\Twiml\VoiceResponse;
./voice/queueing/redirect/queue-redirect.5.x.php:use Twilio\Twiml\VoiceResponse;
./rest/messages/generate-twiml-dynamic-sms/generate-twiml-dynamic-sms.5.x.php:use Twilio\Twiml\MessagingResponse;
./rest/messages/generate-twiml-sms/generate-twiml-sms.5.x.php:use Twilio\Twiml\MessagingResponse;
./rest/messages/generate-twiml-sms-voice/example-1.5.x.php:use Twilio\Twiml\VoiceResponse;
./rest/messages/generate-twiml-mms/generate-twiml-mms.5.x.php:use Twilio\Twiml\MessagingResponse;
./rest/taskrouter/twiml/example2/example/example.5.x.php:use Twilio\Twiml\VoiceResponse;
./rest/taskrouter/twiml/example4/example/example.5.x.php:use Twilio\Twiml\VoiceResponse;
./rest/taskrouter/twiml/example3/example/example.5.x.php:use Twilio\Twiml\VoiceResponse;
./rest/taskrouter/twiml/example1/example/example.5.x.php:use Twilio\Twiml\VoiceResponse;

@bermudezmt
Copy link
Contributor Author

Woof. Thank you for that! Let me merge this PR and then send you a follow-up one.

@bermudezmt bermudezmt merged commit 88746a3 into master Mar 23, 2021
@bermudezmt bermudezmt deleted the change-namespace branch March 23, 2021 19:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants