This repository was archived by the owner on Aug 15, 2024. It is now read-only.
Update namespace from Twiml to TwiML #885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maria Bermudez <bermudez.mt@gmail.com>
bermudezmt
commented
Mar 25, 2021
| @@ -63,7 +63,7 @@ def generate_code_sample_filepath(twiml_filepath, language): | |||
| twiml_filepath, language | |||
| ) | |||
| print("{} -> {}".format(twiml_filepath, code_filepath), end='') | |||
| code_generator = TwimlCodeGenerator( | |||
| code_generator = TwiMLCodeGenerator( | |||
There was a problem hiding this comment.
Oh, just noticed these. Let me push another commit.
There was a problem hiding this comment.
Fixed via 2a37f99
Signed-off-by: Maria Bermudez <bermudez.mt@gmail.com>
|
FYI, @maylonpedroso , I'm seeing this warning on the terminal: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Maria Bermudez bermudez.mt@gmail.com
As pointed out by a customer and Sarah via #883 (comment), the namespace should be
TwiMLinstead of what we had which wasTwiml. @sarahcstringer , can you PTAL?Thanks!