You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This commit was created on GitHub.com and signed with GitHub’s verified signature.
Updated boost library to version 1.92.0
Cleaned up libpng project properties to build pnglibconf.h
Moved a lot of unused/refactored out of existence files to the Archive folder
Refactored! I have enlisted the help of an AI coding agent to finally get around to fixing this 28+ year old code base. It's been a VERY long time coming. First up was to tackle dangling pointers and removing legacy hand-rolled linked list structures. So I replaced every hand-written object list in Source/Wally.
Bug fixes:
PAK
CreateTempName sprintf_s size off by one
List files never appeared: uninitialized LV_ITEM.iItem
Drag-out to Explorer crashed: stack CDelayRender destroyed while Explorer still held IDataObject — heap + ExternalRelease()
Unsaved PAK extract/play: CreateTempFile now exports from the temp data file first
Delete after copy no longer leaves dangling paste pointers
WAD
Same drag-out lifetime bug as PAK
Explorer drag had no CF_HDROP; now exports selected mips as PNG
Merge WAD_MERGE_FIRST_WAD used XOR, so duplicate checks skipped on alternating jobs
Browser
Cache thread GROOM fell through into STOP
Uncompressed-cache case 0 fell through into decompress
Browse view mouse wheel handler existed but did nothing; now scrolls per notch
Build / ART
Tile bounds were uninitialized; each load now clears first
Serialize buffer / CFile leaks on error paths
.art had been routed to CWallyDoc since 2023 (“Unsupported file type”); now uses BuildDocTemplate
.art added to the File MRU
Batch / remip
PNG missing from both 24→8-bit palette switches
JPG/TEX defaulted to 8-bit export and asserted; forced 24-bit
Remip error-diffusion arrays were static (shared across batch threads) → 1px streaks; now stack-local, Random() seed is thread_local
App lifetime / command line
Premature _CrtDumpMemoryLeaks in Run() produced a false leak list
Single-instance: Destroy() now runs before Boost’s intermodule singleton dies (“Dead reference on non-Phoenix singleton”)
Second instance tried to open Wally.exe"; command line now trims quotes/whitespace and skips empty tokens