fix: Module declaration parsed as namespace

[Unnvaldr]

Fixes #1284

I stumbled upon this particular issue and noticed that module declaration lacks ts.NodeFlags.Namespace in AST, so it was very easy to "fix". I've checked if it works, but it may need further investigation.

[Gerrit0]

Thanks for the PR! It looks like there's a problem with this.

module Foo { }

and

namespace Foo { }

Should result in the same output (both are namespaces according to TD).
Eventually, we'll be able to use the cleaner check that you propose, but since the former code block is still valid, we can't use these flags.

---

The TS docs have apparently removed any useful reference to this legacy syntax. It's still on archive.org though. https://web.archive.org/web/20190317062641/https://www.typescriptlang.org/docs/handbook/namespaces-and-modules.html

[Unnvaldr]

The latest commit should address this "misbehaviour".
I had to use casting to any for ts.NodeFlags.Ambient because of being marked as internal and in result missing only in types declaration.

[Gerrit0]

I'm afraid that doesn't work either. Ambient doesn't mean module.

declare module Foo {} // Has Ambient flag
declare namespace Foo2 {} // Has ambient flag

I think the best we can do for now is check ts.isStringLiteral(node.name)

[Unnvaldr]

What you posted is actually the topic of the issue, so everything is taken into the consideration. Ambient declaration is the only exception that have distinguished namespace and module and in result should have separate output. I don't think if double quotes decide about being a module or not

edit: Indeed, the difference is here, so I've changed the method. Though I didn't use your function, but actually a simple kind check, so if this isn't ok feel free to manually alter it. Thanks for pointing out the difference 😃

[Gerrit0]

Using the kind is fine (that's all the function does) but the inline constant could break across different TS versions. We should instead use the enum.

Suggested change

	: createDeclaration(context, node, node.name.kind === 10
	: createDeclaration(context, node, node.name.kind === ts.SyntaxKind.StringLiteral

[Gerrit0]

I should have time later today or tomorrow to pull this down and fix if you don't have time.

[Gerrit0]

Thanks! Should have a release out this weekend.