Preferentially peer with nodes enforcing BIP148 to avoid partitioning risk #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luke-jr
force-pushed
the
uasfsegwit+svcbit
branch
from
50ef0dc
to
3edeff8
Compare
achow101
reviewed
Jun 19, 2017
| @@ -275,6 +275,9 @@ enum ServiceFlags : uint64_t { | |||
| // collisions and other cases where nodes may be advertising a service they | |||
| // do not actually support. Other service bits should be allocated via the | |||
| // BIP process. | |||
|
|
|||
| // NODE_BIP148 means the node enforces BIP 148's mandatory Segwit activation beginning August 1, 2017 | |||
| NODE_BIP148 = (1 << 27), | |||
There was a problem hiding this comment.
Shouldn't this require an addition to the BIP, or at the very least, a mail to bitcoin-dev as stated in the comment above it? Is choosing a temporary service bit a good idea?
There was a problem hiding this comment.
|
utACK 3edeff84a129b875a3e2e0f5af1166acd039557b |
Merged
Github-Pull: bitcoin#10532 Rebased-From: cd74a23fcf9588199e196ab31bc64972400c2027
… risk Github-Pull: bitcoin#10532 Rebased-From: e42a2f6beb61df3e3a201804cf3bcce6b00c88ba
luke-jr
force-pushed
the
uasfsegwit+svcbit
branch
from
3edeff8
to
8c6816f
Compare
|
Rebased |
|
utACK |
1 similar comment
|
utACK |
|
Straightforward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.