fix(ui5-button): prioritize accessibleName over button text in aria-label #12473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…abel When both text content and accessibleName are provided, the aria-label should use only the accessibleName value plus button type text, not concatenate both text content and accessibleName. Fixes #12398
Collaborator
|
🧹 Preview deployment cleaned up: https://pr-12473--ui5-webcomponents.netlify.app |
GDamyanov
approved these changes
Oct 14, 2025
Contributor
GDamyanov
left a comment
GDamyanov
left a comment
There was a problem hiding this comment.
Code looks good.
Good test coverage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
Fixed the aria-label calculation in ui5-button to prioritize accessibleName over button text content when both are provided.
Why
Previously, when both text content and accessibleName were provided, the aria-label would concatenate both values, causing duplication like "Save Save" or "Submit Submit Application". This created poor accessibility experience.
What's Fixed
ariaLabelTextgetter to use conditional logicFixes #12398
Fixes #12442