-
Notifications
You must be signed in to change notification settings - Fork 280
feat(framework): scope theming css variables with component packages #12491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
🧹 Preview deployment cleaned up: https://pr-12491--ui5-webcomponents.netlify.app |
pskelin
approved these changes
Nov 11, 2025
vladitasev
approved these changes
Nov 11, 2025
Collaborator
|
🎉 This PR is included in version v2.17.0-rc.3 🎉 The release is available on v2.17.0-rc.3 Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope and package
--sapCSS variables with the web components package to improve theming reliability and prevent conflicts with external theme dependencies.Some applications and custom themes rely on older versions of
@sap-theming/theming-base-content, resulting in missing CSS variables when detected as external theming. This change ensures components have access to defined variables from newer versions when variables are not added externally, while allowing external variables to override defaults when present.@sap-theming/theming-base-contentwith--ui5-to scope@sap-theming/theming-base-contentas fallbacks per theme - each CSS variable is derived from the original name with default value per theme from theming base content as fallback--sapCSS variables only when externally definedTheme Behavior Expectation
Note: The following behavior applies when external CSS variables are detected when library is booting or when the theme is changing
Standard Theme (sap_horizon):
sap_horizonsap_horizonCustom Theme (my_custom_theme extends sap_horizon):
my_custom_themesap_horizon(maps to base theme)Custom Theme (my_custom_theme extends sap_horizon, used theme is sap_fiori_3):
my_custom_themesap_fiori_3Fixes: #12446