Skip to content

Conversation

@unazko
Copy link
Contributor

@unazko unazko commented Oct 28, 2025

Add input CSS part to DatePicker and TimePicker components to allow styling of the native input element using ::part(input) selector.

  • Add @csspart input documentation for both components
  • Forward part attribute to DateTimeInput in templates
  • Maintains consistency with ui5-input component API
  • Enables scoping-friendly styling without deep selectors

Add input CSS part to DatePicker and TimePicker components to allow
styling of the native input element using ::part(input) selector.

- Add @csspart input documentation for both components
- Forward part attribute to DateTimeInput in templates
- Maintains consistency with ui5-input component API
- Enables scoping-friendly styling without deep selectors

Enhanced accessibility and styling capabilities following
UI5 Web Components Definition of Done guidelines.
@unazko unazko changed the title feat(ui5-date-picker,ui5-time-picker): expose input CSS part for styling fix(ui5-date-picker): add input CSS part for styling Oct 28, 2025
@ui5-webcomponents-bot
Copy link
Collaborator

ui5-webcomponents-bot commented Nov 3, 2025

🧹 Preview deployment cleaned up: https://pr-12559--ui5-webcomponents.netlify.app

@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview November 3, 2025 13:06 Inactive
@GDamyanov GDamyanov self-requested a review November 13, 2025 15:20
Copy link
Contributor

@GDamyanov GDamyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the approach with the part property is approved, cypress test could be added that the property is rendered.

@unazko unazko requested a review from GDamyanov November 17, 2025 12:52
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview November 17, 2025 12:58 Inactive
@unazko unazko requested a review from nnaydenow November 18, 2025 17:12
Copy link
Contributor

@GDamyanov GDamyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Code looks good.
  • Comments addressed.

@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview November 19, 2025 08:39 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview November 19, 2025 14:45 Inactive
@unazko unazko merged commit cacdba0 into main Nov 19, 2025
14 checks passed
@unazko unazko deleted the date_picker_csspart branch November 19, 2025 14:47
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview November 19, 2025 14:47 Inactive
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This PR is included in version v2.17.0-rc.3 🎉

The release is available on v2.17.0-rc.3

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants