-
Notifications
You must be signed in to change notification settings - Fork 280
fix(ui5-date-picker): add input CSS part for styling #12559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add input CSS part to DatePicker and TimePicker components to allow styling of the native input element using ::part(input) selector. - Add @csspart input documentation for both components - Forward part attribute to DateTimeInput in templates - Maintains consistency with ui5-input component API - Enables scoping-friendly styling without deep selectors Enhanced accessibility and styling capabilities following UI5 Web Components Definition of Done guidelines.
|
🧹 Preview deployment cleaned up: https://pr-12559--ui5-webcomponents.netlify.app |
GDamyanov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the approach with the part property is approved, cypress test could be added that the property is rendered.
GDamyanov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Code looks good.
- Comments addressed.
|
🎉 This PR is included in version v2.17.0-rc.3 🎉 The release is available on v2.17.0-rc.3 Your semantic-release bot 📦🚀 |
Add input CSS part to DatePicker and TimePicker components to allow styling of the native input element using ::part(input) selector.