Skip to content

Conversation

@StefanDimitrov04
Copy link
Contributor

JIIRA: BGSOFUIRILA-4149

@ui5-webcomponents-bot
Copy link
Collaborator

ui5-webcomponents-bot commented Nov 10, 2025

🧹 Preview deployment cleaned up: https://pr-12653--ui5-webcomponents.netlify.app

@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview November 10, 2025 13:40 Inactive
@ndeshev
Copy link
Contributor

ndeshev commented Nov 10, 2025

The height of the progress track is 4px and the border is 1px with a content-box box-sizing, this makes the total height 6px, while according to the specs it should be 4px for non-high contrast themes. We should decrease the height to 2px or change the box-sizing to border-box since we are adding a border.

The tag of the pull request shouldn't be "chore", chore is used for "changes to the build process or auxiliary tools and libraries such as documentation generation"(http://localhost:3000/docs/contributing/conventions-and-guidelines/#commit-header). Maybe "fix" is appropriate.

@StefanDimitrov04 StefanDimitrov04 changed the title chore(ui5-slider/ui5-range-slider): add border to progress indicator fix(ui5-slider/ui5-range-slider): add border to progress indicator Nov 11, 2025
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview November 11, 2025 11:08 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview November 11, 2025 12:24 Inactive
@StefanDimitrov04 StefanDimitrov04 merged commit e9fa794 into main Nov 11, 2025
14 checks passed
@StefanDimitrov04 StefanDimitrov04 deleted the slider-vd branch November 11, 2025 16:09
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview November 11, 2025 16:09 Inactive
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This PR is included in version v2.17.0-rc.2 🎉

The release is available on v2.17.0-rc.2

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants