Axis fixes #270
Axis fixes #270
Conversation
R/access-gsplot.R
Outdated
There was a problem hiding this comment.
@jread-usgs check out this function and tell me if I re-invented some other function
There was a problem hiding this comment.
no, we don't have something like this. views(gsplot) just returns the views (removes the other top level things like par and legend).
There was a problem hiding this comment.
cool. It's kind of handy, might be useful for more than just axis.
There was a problem hiding this comment.
Sorry, hard habit to break. I'll quick change it. We are doing _ for functions and . for arguments, right?
|
OK, the pressure to not reduce the coverage is great. Anyway, I'm done. If someone wants to poke around before merging, cool. Otherwise, you can play with the |
There was a problem hiding this comment.
looks like grid happens on top of axis(side=1) in unnamed-chunk-2-1.png, which is why there is a diff for that file. Odd that it doesn't matter for side=3.
There was a problem hiding this comment.
I think it's actually due to not ordering the views anymore. We use to put the bgCol first, then grid, then the rest. I'm planning to move those to a top level thing like axis and par (see #239 ) .
|
Looks great to me. I'd say 👍 for merge |
2 participants
No description provided.