draw_axis handling different data types #396
Conversation
| @@ -88,14 +88,22 @@ axis.gsplot <- function(object, ..., n.minor=0, tcl.minor=0.15, reverse=NULL) { | |||
|
|
|||
| } | |||
|
|
|||
| draw_axis <- function(axis.args){ | |||
| draw_axis <- function(object, side.args){ | |||
There was a problem hiding this comment.
aren't side.args redundant w/ object? How about just object and side or side.name?
| fun.name <- 'axis' | ||
| } else { | ||
| fun.name <- paste0('axis.', class(side.lim)[1L]) | ||
| axis.args$at <- get_axTicks(object, as.side(side.name)) |
There was a problem hiding this comment.
can you remove this line? What does it do? I think you want to let the function axis.class figure out the at
There was a problem hiding this comment.
as.POSIXct and axis.Date don't allow at to be NULL, so I had to define it and then pass it in
There was a problem hiding this comment.
it will just return Error in as.Date(x) : argument "x" is missing, with no default
There was a problem hiding this comment.
Looks like axis.args$at doesn't handle
gs <- gsplot() %>%
points(some_dates, 1:12) %>%
axis(1)
gsThere was a problem hiding this comment.
geez, sorry. I flipped branches too many times trying to track this down. It does handle that as expected.
I am completely confused why you can give axis all those at values and it still only renders the two extremes. This issue has me totally stumped.
|
using |
|
Base and gsplot are matching now Base some_dates <- seq(as.POSIXct("2010-10-01"), as.POSIXct("2011-09-30"), by="month")
plot(some_dates, 1:12)
gsplot gs <- gsplot() %>%
points(some_dates, 1:12)
gs
|
|
Another example: Base library(dataRetrieval)
siteNumber <- '04085427'
startDate <- '2012-01-01'
endDate <- '2012-06-30'
pCode <- '00060'
dv <- readNWISdv(siteNumber,pCode, startDate, endDate)
plot(dv$Date, dv$X_00060_00003)
gsplot gsplot() %>%
points(dv$Date, dv$X_00060_00003)
|
Test for this is in the READMEsee Compatibility with base plotting section date_vector <- seq(as.Date("2010-10-01"), as.Date("2011-09-30"), by="months")
gs <- gsplot() %>%
points(date_vector, 1:12)
gs
points(as.Date("2010-11-15"),2.5)What the plot would look like before this PR: After this PR: |
| @@ -96,8 +96,7 @@ grid_axTicks <- function(object, side){ | |||
| if(is.numeric(lim)){ | |||
| at <- axTicks(side) | |||
| } else{ | |||
| fun <- getFromNamespace(paste0('axis.',class(lim)[1L]),'graphics') | |||
| at <- fun(side, x = lim, lwd=0, lwd.ticks=0, labels = FALSE) | |||
| at <- Axis(side = side, x = pretty(lim), lwd=0, lwd.ticks=0, labels = FALSE) | |||
There was a problem hiding this comment.
Ahh, so this is the key change?
There was a problem hiding this comment.
yep - needed pretty() so that it wasn't just passing two values. Then switched to using Axis because that internally handles all of the axis.[class] stuff
fixing #395
sharing some helper functions with
draw_custom_grid, but not quite to the extent #343 is talking about