Updated to support better error reporting #303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updates samples to use distinct namespace and correct descriptions
* Updated Kaleidoscope parser return type to `IAstNode?` to match interface and intent.
* Changed constructor to `AppControlledDefaultsRootCommand` to make the settings a non-nullable type.
* It makes no sense to use that type unless the settings are provided. The whole point is to make it explicit. So if the default behavior is intended then use the parent type OR explicitly provide a default constructed settings.
* Changed name of `IRootCommand` to `ICommandLineOptions` to better reflect intent and further isolate from `System.CommandLine` parsing.
* Updated the `ArgsParsing.TryParse<>` so that it uses the new `ShowHelpOnErrors` and `ShowTypoCorrections`
* Fixed `ReportingTextWriter` adapter so it correctly handles new lines and blank lines
* Added nullability checks to `ParseErrorReporterExtensions.CheckAndReportParseErrors`
* Added `ParserExtensions` to provide extension that allows parsing from a file (as opposed to parsing a string as input)
* Added override of default color mapping for `ColoredConsoleReporter` updated the default colors
* Corrected bug in reporting string messages for `ConsoleReporter`
* Disabled RUDE OPT-OUT breaking change that forces appending BuildMeta that is NOT desired
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to support better error reporting
IAstNode?to match interface and intent.AppControlledDefaultsRootCommandto make the settings a non-nullable type.IRootCommandtoICommandLineOptionsto better reflect intent and further isolate fromSystem.CommandLineparsing.ArgsParsing.TryParse<>so that it uses the newShowHelpOnErrorsandShowTypoCorrectionsReportingTextWriteradapter so it correctly handles new lines and blank linesParseErrorReporterExtensions.CheckAndReportParseErrorsParserExtensionsto provide extension that allows parsing from a file (as opposed to parsing a string as input)ColoredConsoleReporterupdated the default colorsConsoleReporter