Skip to content

Conversation

jvalenzu
Copy link
Collaborator

Modify the public sample to match internal 0.50 entities samples
Update Editor version to 2020.3.30f1 (1fb1bf06830e)

Joe Valenzuela added 2 commits March 18, 2022 10:56
* Modify the public sample to match internal 0.50 entities samples
* Update Editor version to 2020.3.30f1 (1fb1bf06830e)
@jvalenzu
Copy link
Collaborator Author

Creating a new pull request because apparently my first push created a protected branch that I someone do not have permission to push to.

Old PR:
#204

@jvalenzu
Copy link
Collaborator Author

@BrianWill-Unity This push has URP and AFAIK works without error. I'm not sure why you would have had to create any settings, all the relevant assets should be included.

image

Copy link
Collaborator

@BrianWill-Unity BrianWill-Unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I maybe had a global cache issue. Anyway, after a clean reset with this branch and flushing the Library, it now renders out of the box 👍 .

Copy link
Collaborator

@kjellander-unity kjellander-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I'm a useful reviewer here but this LGTM

@MartinGram MartinGram merged commit 207e3b1 into master Mar 24, 2022
@MartinGram MartinGram deleted the upgrade-to-050-b branch March 24, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants