Skip to content

Allow ShaderGraph generation to generate multiple render state [Skip CI] #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Jul 2, 2020
Merged

Allow ShaderGraph generation to generate multiple render state [Skip CI] #1039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
deb10b5
Custom Passes for Render Graph (#1009)
JulienIgnace-Unity Jun 29, 2020
f7cae22
fix typo in the Render Pipeline Wizard (#1037)
fabien-unity Jun 29, 2020
343c886
Fixed a number of small issue when running XR and Render Graph at the…
JulienIgnace-Unity Jun 29, 2020
25f5842
Fixed shader graph code generation for HDRP unlit shader
alelievr Jun 29, 2020
84f2e5e
Fixed render state leak in Depth forward only pass
alelievr Jun 29, 2020
e820fd2
Renamed the debug name from SSAO to ScreenSpaceAmbientOcclusion (1254…
anisunity Jun 30, 2020
c0506e3
Added an example CloudLayer render texture + rotation for cloud layer…
adrien-de-tocqueville Jun 30, 2020
fe009c1
Fix perf framework ui (#1049)
alelievr Jun 30, 2020
f036923
Added an option to extend the camera culling for skinned mesh animati…
anisunity Jun 30, 2020
e0ddbe9
Change transparent ssr name in frame settings (#1056)
FrancescoC-unity Jun 30, 2020
8702b34
Move CloudLayer Material editor
adrien-de-tocqueville Jun 30, 2020
e54dbc7
Merge branch 'master' into HDRP/staging
sebastienlagarde Jun 30, 2020
287dda2
Correct fallback for ray tracing and light layers (1258837) (#1053)
anisunity Jul 1, 2020
f643e8a
Add missing tooltips in physical camera and improve the UI for apertu…
pmavridis Jul 1, 2020
8f98e57
Merge remote-tracking branch 'origin/master' into sg/fix/multiple-ren…
alelievr Jul 1, 2020
8d46240
Fixed reseed on play overdraw vfx (#1050)
alelievr Jul 1, 2020
cce1fd7
Add defines guards around shadows hlsl files (#1067)
FrancescoC-unity Jul 1, 2020
5ed4159
Fix issue throwing exceptions when trying to do implicit conversions …
FrancescoC-unity Jul 1, 2020
16a0b14
Force scene view redraw upon change of override exposure (#1071)
FrancescoC-unity Jul 1, 2020
f21cd1a
Fixed an error when clearing the SSGI history texture at creation tim…
anisunity Jul 1, 2020
1c1df9b
Slight change of parametrization behaviour (#1080)
FrancescoC-unity Jul 1, 2020
2a067d8
Shader stacks fixes (#1085)
sebastienlagarde Jul 1, 2020
70b71bc
Merge branch 'master' into HDRP/staging
sebastienlagarde Jul 1, 2020
94ce797
Revert: Correct fallback for ray tracing and light layers (1258837) (…
sebastienlagarde Jul 1, 2020
e7b138d
Fixed Look Dev with Light Theme (#1006)
JulienIgnace-Unity Jul 1, 2020
a51e1d8
Merge branch 'HDRP/staging' into sg/fix/multiple-renderstate
sebastienlagarde Jul 2, 2020
f5bc6a7
Merge branch 'master' into sg/fix/multiple-renderstate
sebastienlagarde Jul 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion com.unity.render-pipelines.high-definition/Editor/Material/ShaderGraph/HDShaderPasses.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ public static PassDescriptor GenerateDepthForwardOnlyPass(bool supportLighting)

RenderStateCollection GenerateRenderState()
{
var renderState = CoreRenderStates.DepthOnly;
var renderState = new RenderStateCollection{ CoreRenderStates.DepthOnly };

if (!supportLighting)
{
Expand Down
6 changes: 5 additions & 1 deletion com.unity.shadergraph/Editor/Generation/Processors/Generator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,11 @@ void ProcessStackForPass(ContextData contextData, BlockFieldDescriptor[] passBlo
if(renderState.TestActive(activeFields))
{
renderStateBuilder.AppendLine(renderState.value);
break;

// Cull is the only render state type that causes a compilation error
// when there are multiple Cull directive with different values in a pass.
if (type == RenderStateType.Cull)
break;
}
}
}
Expand Down