Fix an issue with the quality mode and perf mode on RTR and RTGI and getting rid of unwanted nans (1256923) #1055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…getting rid of unwanted nans (1256923)
sebastienlagarde
approved these changes
Jun 30, 2020
remi-chapelain
approved these changes
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two issues were found, the first one was the wrong mode was used in some cases (perf instead of quality even if the volume stated quality). The second issue was the occasional nans happening in the reflection denoiser bcause of data outside of the screen was fetched (that happened to be nans).
https://fogbugz.unity3d.com/f/cases/1256923
The DXT test were ran locally and were green.