Skip to content

Fix emissive mesh layer mask behaviour #1062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 2, 2020
Merged

Fix emissive mesh layer mask behaviour #1062

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
54cf788
Update emissive game object layer mask on validation
FrancescoC-unity Jun 30, 2020
b7ef4dc
changelog
FrancescoC-unity Jun 30, 2020
a202320
Merge branch 'HDRP/staging' into HDRP/fix-emissive-mesh-layer-mask
sebastienlagarde Jul 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -710,6 +710,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed Sorting Priority not displayed correctly in the DrawRenderers custom pass UI.
- Fixed glitch in Project settings window when selecting diffusion profiles in material section (case 1253090)
- Fixed issue with light layers bigger than 8 (and above the supported range).
- Fixed issue with culling layer mask of area light's emissive mesh

### Changed
- Improve MIP selection for decals on Transparents
Expand Down
5 changes: 5 additions & 0 deletions com.unity.render-pipelines.high-definition/Runtime/Lighting/Light/HDAdditionalLightData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2507,6 +2507,11 @@ void OnValidate()

RefreshCachedShadow();

if (emissiveMeshRenderer != null && !emissiveMeshRenderer.Equals(null))
{
emissiveMeshRenderer.gameObject.layer = m_AreaLightEmissiveMeshLayer;
}

#if UNITY_EDITOR
// If modification are due to change on prefab asset, we want to have prefab instances to self-update, but we cannot check in OnValidate if this is part of
// prefab instance. So we delay the check on next update (and before teh LateUpdate logic)
Expand Down