Skip to content

[Backport 7.x.x] Fix emissive mesh layer mask behaviour #1096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[Backport 7.x.x] Fix emissive mesh layer mask behaviour #1096

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8769f03
Update emissive game object layer mask on validation
FrancescoC-unity Jun 30, 2020
c6bb2f3
changelog
FrancescoC-unity Jul 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,15 @@
# Changelog
# Changelog
All notable changes to this package will be documented in this file.

The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [Unreleased]

### Fixed

- Fixed issue with culling layer mask of area light's emissive mesh.

## [7.4.0] - 2020-05-22

### Added
Expand Down
5 changes: 5 additions & 0 deletions com.unity.render-pipelines.high-definition/Runtime/Lighting/Light/HDAdditionalLightData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2350,6 +2350,11 @@ void OnValidate()
DisableCachedShadowSlot();
m_ShadowMapRenderedSinceLastRequest = false;

if (emissiveMeshRenderer != null && !emissiveMeshRenderer.Equals(null))
{
emissiveMeshRenderer.gameObject.layer = m_AreaLightEmissiveMeshLayer;
}

#if UNITY_EDITOR
// If modification are due to change on prefab asset that are non overridden on this prefab instance
if (PrefabUtility.IsPartOfPrefabInstance(this) && ((PrefabUtility.GetCorrespondingObjectFromOriginalSource(this) as HDAdditionalLightData)?.needRefreshPrefabInstanceEmissiveMeshes ?? false))
Expand Down