Disable batch mode for HDRP_DXR_Testing #1230
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read;
PR Workflow for the Graphics repository:
Checklist for PR maker
need-backport-*
label. After you backport the PR, the label changes tobackported-*
.CHANGELOG.md
file.Purpose of this PR
This PR was causing Yamato-only failures that disappeared once batch mode was disabled: #1053
The ideal fix would be to resolve why this is only happening in batch mode and fix that, but due to limited SDET resources, it's better to simply disable batchmode for this project for now. This slows down testing, but eliminates failures that only appear in batchmode.
Testing status
Manual Tests: What did you do?
Automated Tests: What did you setup? (Add a screenshot or the reference image of the test please)
No new tests
Yamato: (Select your branch):
Tested the original PR with batchmode disabled and confirmed no more failures: https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics/tree/HDRP%252FRTPerfLightLayerDebug2/.yamato%252Fhdrp_dxr-win-dx12.yml%2523HDRP_DXR_Win_DX12_playmode_fast-trunk/2741123/job
Comments to reviewers
Should this be backported?