Skip to content

Conversation

nerites
Copy link
Contributor

@nerites nerites commented Jul 9, 2020

Please read;

PR Workflow for the Graphics repository:

  • All PRs must be opened as draft initially
  • Reviewers can be added while the PR is still in draft
  • The PR can be marked as “Ready for Review” once the reviewers have confirmed that no more changes are needed
  • Tests will start automatically after the PR is marked as “Ready for Review”
  • Do not use [skip ci] - this can break some of our tooling
  • Read the Graphics repository & Yamato FAQ.

Checklist for PR maker

  • Have you added a backport label (if needed)? For example, the need-backport-* label. After you backport the PR, the label changes to backported-*.
  • [N/A] Have you updated the changelog? Each package has a CHANGELOG.md file.
  • [N/A] Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR.
  • [N/A] Have you added a graphic test for your PR (if needed)? When you add a new feature, or discover a bug that tests don't cover, please add a graphic test.

Purpose of this PR

This PR was causing Yamato-only failures that disappeared once batch mode was disabled: #1053

The ideal fix would be to resolve why this is only happening in batch mode and fix that, but due to limited SDET resources, it's better to simply disable batchmode for this project for now. This slows down testing, but eliminates failures that only appear in batchmode.


Testing status

Manual Tests: What did you do?

  • Opened test project + Run graphic tests locally
  • [N/A] Built a player
  • [N/A] Checked new UI names with UX convention
  • [N/A] Tested UI multi-edition + Undo/Redo + Prefab overrides + Alignment in Preset
  • [N/A] C# and shader warnings (supress shader cache to see them)
  • [N/A] Checked new resources path for the reloader (in developer mode, you have a button at end of resources that check the paths)
  • Other:

Automated Tests: What did you setup? (Add a screenshot or the reference image of the test please)
No new tests

Yamato: (Select your branch):
Tested the original PR with batchmode disabled and confirmed no more failures: https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics/tree/HDRP%252FRTPerfLightLayerDebug2/.yamato%252Fhdrp_dxr-win-dx12.yml%2523HDRP_DXR_Win_DX12_playmode_fast-trunk/2741123/job


Comments to reviewers

Should this be backported?

@nerites
Copy link
Contributor Author

nerites commented Aug 10, 2020

Closing due to lack of interest.

@nerites nerites closed this Aug 10, 2020
@sebastienlagarde sebastienlagarde deleted the HDRP/DisableBatchModeForDXRTests branch September 1, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants