Skip to content

Fix null reference when processing light probe #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2020
Merged

Fix null reference when processing light probe #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,6 +530,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed compile error with XR SubsystemManager.
- Fix for assertion triggering sometimes when saving a newly created lit shader graph (case 1230996)
- Fixed culling of planar reflection probes that change position (case 1218651)
- Fixed null reference when processing lightprobe (case 1235285)

### Changed
- Color buffer pyramid is not allocated anymore if neither refraction nor distortion are enabled
Expand Down
10 changes: 5 additions & 5 deletions com.unity.render-pipelines.high-definition/Runtime/Lighting/LightLoop/LightLoop.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2506,17 +2506,17 @@ int PreprocessVisibleProbes(HDCamera hdCamera, CullingResults cullResults, HDPro
{
var probe = cullResults.visibleReflectionProbes[probeIndex];

if (probe.reflectionProbe == null
|| probe.reflectionProbe.Equals(null) || !probe.reflectionProbe.isActiveAndEnabled
|| !aovRequest.IsLightEnabled(probe.reflectionProbe.gameObject))
continue;

ref ProcessedProbeData processedData = ref m_ProcessedReflectionProbeData[probeIndex];
PreprocessReflectionProbeData(ref processedData, probe, hdCamera);

if (TrivialRejectProbe(processedData, hdCamera))
continue;

if (probe.reflectionProbe == null
|| probe.reflectionProbe.Equals(null) || !probe.reflectionProbe.isActiveAndEnabled
|| !aovRequest.IsLightEnabled(probe.reflectionProbe.gameObject))
continue;

// Work around the data issues.
if (probe.localToWorldMatrix.determinant == 0)
{
Expand Down