Fixed couple issues in the dependence of building the ray tracing acceleration structure. #1332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eleration structure.
|
It appears that you made a non-draft PR! |
|
Requires a QA pass for sure. |
remi-chapelain
approved these changes
Jul 17, 2020
There was a problem hiding this comment.
All first 3 cases mentionned in the previous PR comments have been addressed and pair tested with @anisunity
I managed to repro the issue with contact shadows before but not after the fix.
sebastienlagarde
approved these changes
Jul 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some issues were reported in this PR: #1278 (comment)
An other issue was reported when launching the wizard on the hd template.
No backport required
Changelog written
No documentation to be added
Added a graphic test
Testing status
Ran the DXR tests locally and they are still passing