Skip to content

Fix PCSS filtering issues on first frame (or cached shadows) #1498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 5, 2020
Merged

Fix PCSS filtering issues on first frame (or cached shadows) #1498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7c03770
Set atlas viewport before softness in request is set
FrancescoC-unity Aug 4, 2020
9b14dac
Changelog
FrancescoC-unity Aug 4, 2020
f4179a0
Merge branch 'HDRP/staging' into HDRP/fix-pcss-filtering-first-frame
sebastienlagarde Aug 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Changelog
# Changelog
All notable changes to this package will be documented in this file.

The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
Expand Down Expand Up @@ -760,6 +760,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fix several issues with physically-based DoF (TAA ghosting of the CoC buffer, smooth layer transitions, etc)
- Fixed CoatMask block appearing when creating lit master node (case 1264632)
- Fixed issue with SceneEV100 debug mode indicator when rescaling the window.
- Fixed issue with PCSS filter being wrong on first frame.

### Changed
- Improve MIP selection for decals on Transparents
Expand Down
3 changes: 2 additions & 1 deletion com.unity.render-pipelines.high-definition/Runtime/Lighting/Light/HDAdditionalLightData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2021,6 +2021,8 @@ internal int UpdateShadowRequest(HDCamera hdCamera, HDShadowManager manager, HDS
if (shadowRequestIndex == -1)
continue;

shadowRequest.atlasViewport = resolutionRequest.atlasViewport;

if (!shadowNeedsRendering)
{
shadowRequest.cachedShadowData.cacheTranslationDelta = cameraPos - m_CachedViewPos;
Expand Down Expand Up @@ -2080,7 +2082,6 @@ internal int UpdateShadowRequest(HDCamera hdCamera, HDShadowManager manager, HDS
SetCommonShadowRequestSettings(shadowRequest, visibleLight, cameraPos, invViewProjection, viewportSize, lightIndex, lightType, filteringQuality);
}

shadowRequest.atlasViewport = resolutionRequest.atlasViewport;
manager.UpdateShadowRequest(shadowRequestIndex, shadowRequest, shadowIsInCachedSystem);

if(shadowIsInCachedSystem && shadowNeedsRendering)
Expand Down