Skip to content

Make sure diffusion profile is correct upon its editor reset #1538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 8, 2020
Merged

Make sure diffusion profile is correct upon its editor reset #1538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b9171b6
Change the profile every time the inspector is on
FrancescoC-unity Aug 6, 2020
930934a
Changelog
FrancescoC-unity Aug 6, 2020
c4abd71
Merge branch 'HDRP/staging' into HDPR/fix-diffusion-profile-reset
sebastienlagarde Sep 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed ArgumentNullException when saving shader graphs after removing the compositor from the scene (case 1268658)
- Fixed issue with updating the compositor output when not in play mode (case 1266216)
- Fixed warning with area mesh (case 1268379)
- Fixed issue with diffusion profile not being updated upon reset of the editor.

### Changed
- Preparation pass for RTSSShadows to be supported by render graph.
Expand Down
4 changes: 3 additions & 1 deletion ...elines.high-definition/Editor/Material/DiffusionProfile/DiffusionProfileSettingsEditor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,9 @@ public override void OnInspectorGUI()

serializedObject.ApplyModifiedProperties();

if (scope.changed)
// NOTE: We cannot change only upon scope changed since there is no callback when Reset is triggered for Editor and the scope is not changed when Reset is called.
// The following operations are not super cheap, but are not overly expensive, so we instead trigger the change every time inspector is drawn.
// if (scope.changed)
{
// Validate and update the cache for this profile only
profile.objReference.Validate();
Expand Down