Skip biquadratic resampling if volumetric fog filtering is on (saves 0.4ms) #1756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears that you made a non-draft PR! |
sebastienlagarde
approved these changes
Sep 9, 2020
EvgeniiG
reviewed
Sep 9, 2020
|
|
||
| if (_EnableVolumetricFog != 0) | ||
| { | ||
| bool doBiquadraticReconstruction = _VolumetricFilteringEnabled < 0.5f; // Only if filtering is disabled. |
There was a problem hiding this comment.
This is weird, just compare it with 0. More efficient as well.
There was a problem hiding this comment.
You could also pass an int.
There was a problem hiding this comment.
This is actually a leftover of an experimentation I was doing, will change!
EvgeniiG
approved these changes
Sep 9, 2020
sebastienlagarde
deleted the
HDRP/skip-biquadratic-volumetric-sampling-when-filtered
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When filtering is enabled I couldn't see any perceivable difference in having the biquadratic resampling when sampling the vbuffer during the OpaqueAtmosphereScattering pass. On the other hand the difference is much stronger if filtering is off, so the predication of the biquadratic resampling is based on whether the filtering is on or not.
This saves around 0.4ms on PS4 on the template scene.