Override LOD settings with the one from HDRP #1823
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to have consistent behavior with the camera editor
adrien-de-tocqueville
requested review from
JulienIgnace-Unity and
sebastienlagarde
adrien-de-tocqueville
changed the title
|
It appears that you made a non-draft PR! |
JMargevics
approved these changes
Sep 18, 2020
|
The fix is included in a bigger LoD related PR: #2072 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for https://fogbugz.unity3d.com/f/cases/1211957/
and https://fogbugz.unity3d.com/f/cases/1264734/
HDRP overrides the lod settings from QualitySettings just when rendering, then put back to their initial values.
So when the LODGroup component inspector is draw, it uses some meaningless values.
But for rendering, the lod settings can be changed by the framesettings, so I use the one from the HDRP default frame settings, which are the one used by the editor camera.
I tested that the value displayed in the LODGroup inspector is correct
and that the LOD transitions in the viewport match the UI