Skip to content

Conversation

joeante
Copy link
Contributor

@joeante joeante commented Sep 15, 2020

Double perceived performance of HDRP in edit mode
https://docs.google.com/document/d/1xFaK-pFI1XHdngCkXg4HK16x7QJieGy32OMTJf7RpeI/edit

This branch is also necessary:
https://ono.unity3d.com/unity/unity/pull-request/112421/_/graphics/repaint-dirty-fixes

Please read;

PR Workflow for the Graphics repository:

  • All PRs must be opened as draft initially
  • Reviewers can be added while the PR is still in draft
  • The PR can be marked as “Ready for Review” once the reviewers have confirmed that no more changes are needed
  • Tests will start automatically after the PR is marked as “Ready for Review”
  • Do not use [skip ci] - this can break some of our tooling
  • Read the Graphics repository & Yamato FAQ.

Checklist for PR maker

  • Have you added a backport label (if needed)? For example, the need-backport-* label. After you backport the PR, the label changes to backported-*.
  • Have you updated the changelog? Each package has a CHANGELOG.md file.
  • Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR. If you do add documentation, make sure to add the relevant Graphics Docs team member as a reviewer of the PR. If you are not sure which person to add, see the Docs team contacts sheet.
  • Have you added a graphic test for your PR (if needed)? When you add a new feature, or discover a bug that tests don't cover, please add a graphic test.

Purpose of this PR

Why is this PR needed, what hard problem is it solving/fixing?


Testing status

Manual Tests: What did you do?

  • Opened test project + Run graphic tests locally
  • Built a player
  • Checked new UI names with UX convention
  • Tested UI multi-edition + Undo/Redo + Prefab overrides + Alignment in Preset
  • C# and shader warnings (supress shader cache to see them)
  • Checked new resources path for the reloader (in developer mode, you have a button at end of resources that check the paths)
  • Other:

Automated Tests: What did you setup? (Add a screenshot or the reference image of the test please)

Yamato: (Select your branch):
https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics

Any test projects to go with this to help reviewers?


Comments to reviewers

Notes for the reviewers you have assigned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants