Skip to content

Default contact shadow LIGHT quality setting set to true on High #1911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 25, 2020
Merged

Default contact shadow LIGHT quality setting set to true on High #1911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a874f18
Have contact shadow on high quality.
FrancescoC-unity Sep 17, 2020
6ef7b13
changelog
FrancescoC-unity Sep 17, 2020
c519951
Merge branch 'HDRP/staging' into HDRP/default-contact-shadow-quality-…
sebastienlagarde Sep 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed for lookdev library field not being refreshed upon opening a library from the environment library inspector.
- Fixed serialization issue with matcap scale intensity.
- Close Add Override popup of Volume Inspector when the popup looses focus (case 1258571)
- Light quality setting for contact shadow set to on for High quality by default.

### Changed
- Preparation pass for RTSSShadows to be supported by render graph.
Expand Down
7 changes: 7 additions & 0 deletions ...ender-pipelines.high-definition/Runtime/RenderPipeline/Settings/RenderPipelineSettings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ public enum SupportedRayTracingMode
xrSettings = GlobalXRSettings.NewDefault(),
postProcessQualitySettings = GlobalPostProcessingQualitySettings.NewDefault(),
lightingQualitySettings = GlobalLightingQualitySettings.NewDefault(),
lightSettings = LightSettings.NewDefault(),

supportRayTracing = false,
supportedRayTracingMode = SupportedRayTracingMode.Both,
Expand All @@ -140,6 +141,12 @@ public struct LightSettings
{
/// <summary>Enable contact shadows.</summary>
public BoolScalableSetting useContactShadow;

internal static LightSettings NewDefault() => new LightSettings()
{
useContactShadow = new BoolScalableSetting(new[] { false, false, true }, ScalableSettingSchemaId.With3Levels)
};

}

// Lighting
Expand Down