Skip to content

Moving function to internal and adding doc for missing param in planar reflection function #1926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 25, 2020
Merged

Moving function to internal and adding doc for missing param in planar reflection function #1926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8aa292
Moving function to internal and adding doc for missing param in plana…
anisunity Sep 17, 2020
46166ce
Merge branch 'HDRP/staging' into HDRP/fix-missing-docs
sebastienlagarde Sep 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...pipelines.high-definition/Runtime/Lighting/Shadow/ScreenSpaceShadowManager.RenderGraph.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ namespace UnityEngine.Rendering.HighDefinition
{
public partial class HDRenderPipeline
{
public TextureHandle CreateScreenSpaceShadowTextureArray(RenderGraph renderGraph)
internal TextureHandle CreateScreenSpaceShadowTextureArray(RenderGraph renderGraph)
{
int numShadowTextures = Math.Max((int)Math.Ceiling(m_Asset.currentPlatformRenderPipelineSettings.hdShadowInitParams.maxScreenSpaceShadowSlots / 4.0f), 1);
GraphicsFormat graphicsFormat = (GraphicsFormat)m_Asset.currentPlatformRenderPipelineSettings.hdShadowInitParams.screenSpaceShadowBufferFormat;
Expand Down
2 changes: 1 addition & 1 deletion ...elines.high-definition/Runtime/RenderPipeline/Raytracing/HDRaytracingRecursiveRenderer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ void InitRecursiveRenderer()
m_FlagMaskTextureRT = RTHandles.Alloc(Vector2.one, TextureXR.slices, colorFormat: GraphicsFormat.R8_SNorm, dimension: TextureXR.dimension, enableRandomWrite: true, useDynamicScale: true, useMipMap: false, name: "FlagMaskTexture");
}

public TextureHandle CreateFlagMaskTexture(RenderGraph renderGraph)
internal TextureHandle CreateFlagMaskTexture(RenderGraph renderGraph)
{
return renderGraph.CreateTexture(new TextureDesc(Vector2.one, true, true)
{
Expand Down
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/Runtime/Utilities/HDRenderUtilities.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,6 +371,7 @@ public static RenderTexture CreateReflectionProbeRenderTarget(int cubemapSize, G
/// Create the texture used as target for a realtime planar reflection probe.
/// </summary>
/// <param name="planarSize">The size of the texture</param>
/// <param name="format">The planar's format. It must match the format set in the asset.</param>
/// <returns>The texture used as planar reflection probe target</returns>
public static RenderTexture CreatePlanarProbeRenderTarget(int planarSize, GraphicsFormat format)
{
Expand Down