Skip to content

Fix for lens distortion breaking rendering #1938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 29, 2020
Merged

Fix for lens distortion breaking rendering #1938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
39dbaa4
Do different check to see if lens distortion is on
FrancescoC-unity Sep 18, 2020
99b5ecc
Changelog
FrancescoC-unity Sep 18, 2020
88b9c18
Merge branch 'HDRP/staging' into HDRP/fix-lens-distortion-assumed-on-…
sebastienlagarde Sep 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed cubemap static preview not updated when the asset is imported.
- Fixed wizard DXR setup on non-DXR compatible devices.
- Fixed Custom Post Processes affecting preview cameras.
- Fixed issue with lens distortion breaking rendering.

### Changed
- Preparation pass for RTSSShadows to be supported by render graph.
Expand Down
2 changes: 1 addition & 1 deletion ...nity.render-pipelines.high-definition/Runtime/PostProcessing/Components/LensDistortion.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public sealed class LensDistortion : VolumeComponent, IPostProcessComponent
/// <returns><c>true</c> if the effect should be rendered, <c>false</c> otherwise.</returns>
public bool IsActive()
{
return !Mathf.Approximately(intensity.value, 0f)
return Mathf.Abs(intensity.value) > 0
&& (xMultiplier.value > 0f || yMultiplier.value > 0f);
}
}
Expand Down