Skip to content

Fixed wizard DXR setup for non-compatible systems #2003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 29, 2020
Merged

Fixed wizard DXR setup for non-compatible systems #2003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
942baae
Fixed wizard DXR setup for non-compatible systems
alelievr Sep 24, 2020
09cd656
Updated changelog
alelievr Sep 24, 2020
fa50905
Merge branch 'HDRP/staging' into HDRP/fix/wizzard-hardware-fix
sebastienlagarde Sep 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed Cutoff not working properly with ray tracing shaders default and SG (case 1261292).
- Fixed shader compilation issue with Hair shader and debug display mode
- Fixed cubemap static preview not updated when the asset is imported.
- Fixed wizard DXR setup on non-DXR compatible devices.

### Changed
- Preparation pass for RTSSShadows to be supported by render graph.
Expand Down
5 changes: 4 additions & 1 deletion com.unity.render-pipelines.high-definition/Editor/Wizard/HDWizard.Configuration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,14 +633,17 @@ void CheckPersistantNeedReboot()

bool IsDXRAssetCorrect()
=> HDRenderPipeline.defaultAsset != null
&& HDRenderPipeline.defaultAsset.renderPipelineRayTracingResources != null;
&& HDRenderPipeline.defaultAsset.renderPipelineRayTracingResources != null
&& SystemInfo.supportsRayTracing;
void FixDXRAsset(bool fromAsyncUnused)
{
if (!IsHdrpAssetUsedCorrect())
FixHdrpAssetUsed(fromAsync: false);
HDRenderPipeline.defaultAsset.renderPipelineRayTracingResources
= AssetDatabase.LoadAssetAtPath<HDRenderPipelineRayTracingResources>(HDUtils.GetHDRenderPipelinePath() + "Runtime/RenderPipelineResources/HDRenderPipelineRayTracingResources.asset");
ResourceReloader.ReloadAllNullIn(HDRenderPipeline.defaultAsset.renderPipelineRayTracingResources, HDUtils.GetHDRenderPipelinePath());
if (!SystemInfo.supportsRayTracing)
Debug.LogError("Your hardware and/or OS don't support DXR!");
}

bool IsDXRScreenSpaceShadowCorrect()
Expand Down