[9.x.x][ShaderGraph] Backport of color deprecation and versioning system #2120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdxntchou
approved these changes
Oct 12, 2020
ghost
reviewed
Oct 14, 2020
There was a problem hiding this comment.
Things tested:
- Confirmed that Property -> Inline and back is the same in Universal for both Linear and Gamma space
- Confirmed that Property -> Inline and back is the same in HDRP in Linear space
- Confirmed ability to create deprecated node or property with proper option enabled in preferences
- Confirmed node updating works for both inline and property with "show deprecated" on
- Confirmed "hover for info" tooltip works
- Confirmed node updating works for both inline and property with "show deprecated" off
- Updated node from before PR and confirmed color property and inline become deprecated and can be upgraded
Repro steps for bug
- Gamma space, universal RP, new lit shadergraph, show deprecated nodes on. Make sure you have a scene with HDR color enabled, post processing enabled, and a volume with bloom and intensity set to 1
- Create a deprecated color node with HDR and intensity above 0, click it and upgrade it in the graph inspector
- Plug it into emission
- Save the shadergraph, put it on material on a sphere in your scene
- Convert the color property node to inline
- Look at the change in bloom level on object in scene
Alternative to step 5: instead of converting it to inline, duplicate it and plug the duplicated property into emission
This bug reproduces on Master which means it was a problem with the original PR. Will await further instruction on what to do about it.
ghost
self-requested a review
ghost
approved these changes
Oct 14, 2020
There was a problem hiding this comment.
Pretty sure the bug that's happening has nothing to do with this PR. In practice the result of the bug is an HDR color that has a specific color in the preview and in the shadergraph but is black in the material. I can't figure out how to consistently reproduce this bug but I did reproduce it once on master. I don't think it's caused by this PR so I'm going to approve.
marctem
approved these changes
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #1413
Ran graphics tests in ShaderGraph test project locally