Skip to content

Migrate DecalNormalPatch fix to RenderGraph version to avoid Metal validation error #2203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2020
Merged

Migrate DecalNormalPatch fix to RenderGraph version to avoid Metal validation error #2203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion ...unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.Prepass.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -846,6 +846,13 @@ void RenderDBuffer(RenderGraph renderGraph, HDCamera hdCamera, TextureHandle dec

void DecalNormalPatch(RenderGraph renderGraph, HDCamera hdCamera, ref PrepassOutput output)
{
// Integrated Intel GPU on Mac don't support the texture format use for normal (RGBA_8UNORM) for SetRandomWriteTarget
// So on Metal for now we don't patch normal buffer if we detect an intel GPU
if (SystemInfo.graphicsDeviceType == GraphicsDeviceType.Metal && SystemInfo.graphicsDeviceName.Contains("Intel"))
{
return;
}

if (hdCamera.frameSettings.IsEnabled(FrameSettingsField.Decals) &&
!hdCamera.frameSettings.IsEnabled(FrameSettingsField.MSAA)) // MSAA not supported
{
Expand Down Expand Up @@ -876,7 +883,7 @@ class DownsampleDepthForLowResPassData
public TextureHandle depthTexture;
public TextureHandle downsampledDepthBuffer;

// Data needed for potentially writing
// Data needed for potentially writing
public Vector2Int mip0Offset;
public bool computesMip1OfAtlas;
}
Expand Down
6 changes: 3 additions & 3 deletions com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -817,7 +817,7 @@ void DestroyRenderTextures()

RTHandles.Release(m_DistortionBuffer);
RTHandles.Release(m_ContactShadowBuffer);

RTHandles.Release(m_LowResTransparentBuffer);

// RTHandles.Release(m_SsrDebugTexture);
Expand Down Expand Up @@ -2740,7 +2740,7 @@ void Callback(CommandBuffer c, HDGPUAsyncTaskParams a)
void AsyncSSAODispatch(CommandBuffer c, HDGPUAsyncTaskParams a)
=> m_AmbientOcclusionSystem.Dispatch(c, a.hdCamera, depthTexture, normalBuffer, motionVectors, a.frameCount);
}

using (new ProfilingScope(cmd, ProfilingSampler.Get(HDProfileId.RenderShadowMaps)))
{
// This call overwrites camera properties passed to the shader system.
Expand Down Expand Up @@ -3871,7 +3871,7 @@ void DecalNormalPatch(HDCamera hdCamera, CommandBuffer cmd)
{
// Integrated Intel GPU on Mac don't support the texture format use for normal (RGBA_8UNORM) for SetRandomWriteTarget
// So on Metal for now we don't patch normal buffer if we detect an intel GPU
if (SystemInfo.graphicsDeviceType == GraphicsDeviceType.Metal /* && SystemInfo.graphicsDeviceName.Contains("Intel") */)
if (SystemInfo.graphicsDeviceType == GraphicsDeviceType.Metal && SystemInfo.graphicsDeviceName.Contains("Intel"))
{
return;
}
Expand Down