Skip to content

Conversation

sebastienlagarde
Copy link
Contributor

Please read;

PR Workflow for the Graphics repository:

  • All PRs must be opened as draft initially
  • Reviewers can be added while the PR is still in draft
  • The PR can be marked as “Ready for Review” once the reviewers have confirmed that no more changes are needed
  • Tests will start automatically after the PR is marked as “Ready for Review”
  • Do not use [skip ci] - this can break some of our tooling
  • Read the Graphics repository & Yamato FAQ.

Checklist for PR maker

  • Have you added a backport label (if needed)? For example, the need-backport-* label. After you backport the PR, the label changes to backported-*.
  • Have you updated the changelog? Each package has a CHANGELOG.md file.
  • Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR. If you do add documentation, make sure to add the relevant Graphics Docs team member as a reviewer of the PR. If you are not sure which person to add, see the Docs team contacts sheet.
  • Have you added a graphic test for your PR (if needed)? When you add a new feature, or discover a bug that tests don't cover, please add a graphic test.

Purpose of this PR

Why is this PR needed, what hard problem is it solving/fixing?


Testing status

Describe what manual/automated tests were performed for this PR


Comments to reviewers

Notes for the reviewers you have assigned.

@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page)
and cancel any jobs that started on Yamato.
See the PR template for more information.
Thank you!

@sebastienlagarde sebastienlagarde merged commit 39dddaa into HDRP/staging Oct 14, 2020
@sebastienlagarde sebastienlagarde deleted the HDRP/misc-fix-10-1 branch October 14, 2020 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant