Skip to content

HDRP - Fix XR shadows culling #2263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 30, 2020
Merged

HDRP - Fix XR shadows culling #2263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f2aa6c6
fix XR shadows culling
fabien-unity Oct 16, 2020
4b48ecf
Merge branch 'master' into HDRP/xr/fov-shadows-cull-2
sebastienlagarde Oct 22, 2020
a340a84
do not update the fieldOfView if usePhysicalProperties is active
fabien-unity Oct 29, 2020
1d4a2a7
Merge branch 'master' into HDRP/xr/fov-shadows-cull-2
fabien-unity Oct 29, 2020
5aff78e
re-add changelog entry
fabien-unity Oct 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## [11.0.0] - 2020-10-21

### Fixed
- Fixed XR shadows culling

Version Updated
The version number for this package has increased due to a version update of a related graphics package.

Expand Down
4 changes: 4 additions & 0 deletions com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3295,6 +3295,10 @@ out ScriptableCullingParameters cullingParams
if (hdCamera.xr.enabled)
{
cullingParams = hdCamera.xr.cullingParams;

// Sync the FOV on the camera to match the projection from the XR device in order to cull shadows accurately
if (!camera.usePhysicalProperties)
camera.fieldOfView = Mathf.Rad2Deg * Mathf.Atan(1.0f / cullingParams.stereoProjectionMatrix.m11) * 2.0f;
}
else
{
Expand Down