Skip to content

Fixed a warning happening when putting the range of lights to 0 (case 1284682) #2264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 25, 2020
Merged

Fixed a warning happening when putting the range of lights to 0 (case 1284682) #2264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6fde83e
Fixed a warning happening when putting the range of lights to 0.
anisunity Oct 16, 2020
1b4b08c
Merge branch 'master' into HDRP/fix-range0-1284682
sebastienlagarde Oct 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ The version number for this package has increased due to a version update of a r
- Fixed undo after enabling compositor.
- Fixed the ray tracing shadow UI being displayed while it shouldn't (case 1286391).
- Fixed issues with physically-based DoF, improved speed and robustness
- Fixed a warning happening when putting the range of lights to 0.

### Changed
- Combined occlusion meshes into one to reduce draw calls and state changes with XR single-pass.
Expand Down
3 changes: 3 additions & 0 deletions com.unity.render-pipelines.high-definition/Editor/Lighting/HDLightUI.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -732,6 +732,9 @@ static void DrawEmissionContent(SerializedHDLight serialized, Editor owner)
#else
serialized.settings.DrawRange(false);
#endif
// Make sure the range is not 0.0
serialized.settings.range.floatValue = Mathf.Max(0.001f, serialized.settings.range.floatValue);

if (EditorGUI.EndChangeCheck())
{
// For GI we need to detect any change on additional data and call SetLightDirty + For intensity we need to detect light shape change
Expand Down