Skip to content

Update default directional light intensity in HDRP #2275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 22, 2020
Merged

Update default directional light intensity in HDRP #2275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4baf639
Updated directional light default intensity to 100k lux
JulienIgnace-Unity Oct 19, 2020
bcced33
Updated outdoor scene templates to have 130k directional instead of 110k
JulienIgnace-Unity Oct 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions ...unity.render-pipelines.high-definition/Editor/SceneTemplates/Outdoors/OutdoorsScene.unity
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ RenderSettings:
m_ReflectionIntensity: 1
m_CustomReflection: {fileID: 0}
m_Sun: {fileID: 0}
m_IndirectSpecularColor: {r: 0, g: 0, b: 0, a: 1}
m_IndirectSpecularColor: {r: 2155.1436, g: 2259.3691, b: 3297.336, a: 1}
m_UseRadianceAmbientProbe: 0
--- !u!157 &3
LightmapSettings:
Expand Down Expand Up @@ -153,7 +153,7 @@ Light:
m_Type: 1
m_Shape: 0
m_Color: {r: 1, g: 1, b: 1, a: 1}
m_Intensity: 110000
m_Intensity: 130000
m_Range: 10
m_SpotAngle: 30
m_InnerSpotAngle: 21.80208
Expand Down Expand Up @@ -194,7 +194,7 @@ Light:
m_RenderingLayerMask: 1
m_Lightmapping: 4
m_LightShadowCasterMode: 2
m_AreaSize: {x: 1, y: 1}
m_AreaSize: {x: 0.5, y: 0.5}
m_BounceIntensity: 1
m_ColorTemperature: 6500
m_UseColorTemperature: 1
Expand Down Expand Up @@ -237,7 +237,7 @@ MonoBehaviour:
m_PointlightHDType: 0
m_SpotLightShape: 0
m_AreaLightShape: 0
m_Intensity: 110000
m_Intensity: 130000
m_EnableSpotReflector: 0
m_LuxAtDistance: 1
m_InnerSpotPercent: 0
Expand Down Expand Up @@ -311,6 +311,10 @@ MonoBehaviour:
m_NormalBias: 0.75
m_SlopeBias: 0.5
m_ShadowUpdateMode: 0
m_AlwaysDrawDynamicShadows: 0
m_UpdateShadowOnLightMovement: 0
m_CachedShadowTranslationThreshold: 0.01
m_CachedShadowAngularThreshold: 0.5
m_BarnDoorAngle: 90
m_BarnDoorLength: 0.05
m_preserveCachedShadow: 0
Expand Down
12 changes: 8 additions & 4 deletions ...render-pipelines.high-definition/Editor/SceneTemplates/OutdoorsDXR/OutdoorsDXRScene.unity
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ RenderSettings:
m_ReflectionIntensity: 1
m_CustomReflection: {fileID: 0}
m_Sun: {fileID: 0}
m_IndirectSpecularColor: {r: 0, g: 0, b: 0, a: 1}
m_IndirectSpecularColor: {r: 2155.1436, g: 2259.3691, b: 3297.336, a: 1}
m_UseRadianceAmbientProbe: 0
--- !u!157 &3
LightmapSettings:
Expand Down Expand Up @@ -153,7 +153,7 @@ Light:
m_Type: 1
m_Shape: 0
m_Color: {r: 1, g: 1, b: 1, a: 1}
m_Intensity: 110000
m_Intensity: 130000
m_Range: 10
m_SpotAngle: 30
m_InnerSpotAngle: 21.80208
Expand Down Expand Up @@ -194,7 +194,7 @@ Light:
m_RenderingLayerMask: 1
m_Lightmapping: 4
m_LightShadowCasterMode: 2
m_AreaSize: {x: 1, y: 1}
m_AreaSize: {x: 0.5, y: 0.5}
m_BounceIntensity: 1
m_ColorTemperature: 6500
m_UseColorTemperature: 1
Expand Down Expand Up @@ -237,7 +237,7 @@ MonoBehaviour:
m_PointlightHDType: 0
m_SpotLightShape: 0
m_AreaLightShape: 0
m_Intensity: 110000
m_Intensity: 130000
m_EnableSpotReflector: 0
m_LuxAtDistance: 1
m_InnerSpotPercent: 0
Expand Down Expand Up @@ -311,6 +311,10 @@ MonoBehaviour:
m_NormalBias: 0.75
m_SlopeBias: 0.5
m_ShadowUpdateMode: 0
m_AlwaysDrawDynamicShadows: 0
m_UpdateShadowOnLightMovement: 0
m_CachedShadowTranslationThreshold: 0.01
m_CachedShadowAngularThreshold: 0.5
m_BarnDoorAngle: 90
m_BarnDoorLength: 0.05
m_preserveCachedShadow: 0
Expand Down
8 changes: 4 additions & 4 deletions com.unity.render-pipelines.high-definition/Runtime/Lighting/Light/HDAdditionalLightData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public static BoolScalableSetting UseContactShadow(HDRenderPipelineAsset hdrp) =
/// <summary>
/// The default intensity value for directional lights in Lux
/// </summary>
public const float k_DefaultDirectionalLightIntensity = Mathf.PI; // In lux
public const float k_DefaultDirectionalLightIntensity = 100000; // In lux
/// <summary>
/// The default intensity value for punctual lights in Lumen
/// </summary>
Expand Down Expand Up @@ -1438,7 +1438,7 @@ public bool alwaysDrawDynamicShadows
bool m_UpdateShadowOnLightMovement = false;
/// <summary>
/// Whether a cached shadow map will be automatically updated when the light transform changes (more than a given threshold set via cachedShadowTranslationUpdateThreshold
/// and cachedShadowAngleUpdateThreshold).
/// and cachedShadowAngleUpdateThreshold).
/// </summary>
/// <value></value>
public bool updateUponLightMovement
Expand Down Expand Up @@ -1479,7 +1479,7 @@ public float cachedShadowTranslationUpdateThreshold
[SerializeField]
float m_CachedShadowAngularThreshold = 0.5f;
/// <summary>
/// If any transform angle of the light is over this threshold (in degrees) since last update, a cached shadow which is set to update upon light movement
/// If any transform angle of the light is over this threshold (in degrees) since last update, a cached shadow which is set to update upon light movement
/// (updateUponLightMovement from script or Update on Light Movement in UI) is updated.
/// </summary>
public float cachedShadowAngleUpdateThreshold
Expand Down Expand Up @@ -2156,7 +2156,7 @@ internal int UpdateShadowRequest(HDCamera hdCamera, HDShadowManager manager, HDS

shadowRequest.isInCachedAtlas = isSampledFromCache;
shadowRequest.isMixedCached = updateType == ShadowMapUpdateType.Mixed;
shadowRequest.shouldUseCachedShadowData = false;
shadowRequest.shouldUseCachedShadowData = false;

Vector2 viewportSize = resolutionRequest.resolution;

Expand Down