Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
dc7af54
Null guard and warning
FrancescoC-unity Oct 22, 2020
8b232f4
Changelog
FrancescoC-unity Oct 22, 2020
0a6ab77
Fixing exceptions in the console when putting the SSGI in low quality…
anisunity Oct 22, 2020
41d1f0f
Add VT frame settings (#2286)
FrancescoC-unity Oct 23, 2020
bdcb8ba
Fix undo/redo compositor (#2300)
adrien-de-tocqueville Oct 23, 2020
bc54701
Restored purge of unused resources in render graph (#2306)
JulienIgnace-Unity Oct 23, 2020
4b8ed51
Improve punctual shadow resolution rescale algorithm (#2309)
alelievr Oct 23, 2020
60cb43c
Remove unused references of the HDRP asset in decal code (#2326)
FrancescoC-unity Oct 23, 2020
a03e874
Fix diffusion profile dependency (#2327)
alelievr Oct 23, 2020
58152f0
Standardize naming for Transparent receive SSR (#2329)
FrancescoC-unity Oct 23, 2020
1dab24b
Merge branch 'master' of https://github.com/Unity-Technologies/Graphi…
JulienIgnace-Unity Oct 23, 2020
ac15c43
Revert "Standardize naming for Transparent receive SSR (#2329)"
JulienIgnace-Unity Oct 23, 2020
43339d1
Improvements to the DXR Wizard (#2295)
anisunity Oct 23, 2020
5f489fd
Expose HDRP shader tag IDs and per object config (#2292)
alelievr Oct 23, 2020
6dda2a7
- Updated the documentation about shadow matte and SSShadow and RTSha…
anisunity Oct 23, 2020
56884cf
Fixed warnings when new input system is enabled (#2274)
alelievr Oct 23, 2020
f06c32a
Fix nan when decal affect normals (#2319)
adrien-de-tocqueville Oct 23, 2020
e4dea8d
Fix bleeding of a view into another caused by TAA (#2317)
FrancescoC-unity Oct 23, 2020
d02178e
Reset RT Handle size every now and then in editor if set to a big res…
FrancescoC-unity Oct 23, 2020
4c5a41f
Hdrp/standardize transparent receive ssr (#2338)
JulienIgnace-Unity Oct 23, 2020
bb62e50
Added default volume profile asset change to the undo stack (case 128…
eturquin Oct 23, 2020
9d0bab3
Restored default directional light intensity constant (#2345)
JulienIgnace-Unity Oct 23, 2020
1361f1b
Fixed changelog
JulienIgnace-Unity Oct 23, 2020
e0fa6c7
More changelog fix
JulienIgnace-Unity Oct 23, 2020
eda4327
Remove useless menu entry (#2335)
adrien-de-tocqueville Oct 23, 2020
ff96dd6
Fixed the ray tracing shadow UI being displayed while it shouldn't (c…
anisunity Oct 23, 2020
63b8bc4
Add fade distance for light impact on volumetrics (#2291)
FrancescoC-unity Oct 23, 2020
d66bf90
Fix bit in FrameSettings
sebastienlagarde Oct 23, 2020
32ba2a8
Update sample cubemap image
sebastienlagarde Oct 23, 2020
5772816
Revert "Update sample cubemap image"
sebastienlagarde Oct 24, 2020
e2786f1
revert: Improve punctual shadow resolution rescale algorithm (#2309)
sebastienlagarde Oct 24, 2020
4b0cb11
Merge branch 'master' into hd/bugfix
sebastienlagarde Oct 24, 2020
bdd18e5
Update TestCaseFilters.asset
sebastienlagarde Oct 24, 2020
d7aba2c
Merge branch 'master' into hd/bugfix
sebastienlagarde Oct 24, 2020
b760548
Merge branch 'master' into hd/bugfix
sebastienlagarde Oct 24, 2020
38b1413
Update SG_DS_Flipped.mat
sebastienlagarde Oct 24, 2020
31abc85
update settings
sebastienlagarde Oct 24, 2020
82d3b18
Update CHANGELOG.md
sebastienlagarde Oct 24, 2020
ce8389b
remove test case filter in runtime test
sebastienlagarde Oct 24, 2020
5011547
migrate correctly to enable virtual texturing.
sebastienlagarde Oct 24, 2020
a1a10eb
Merge branch 'master' into hd/bugfix
sebastienlagarde Oct 24, 2020
ef2fffe
revert some change one in Hdrp/standardize transparent receive ssr #2338
sebastienlagarde Oct 24, 2020
3e26614
Fix breaking change in CoreEditorUtils.cs
sebastienlagarde Oct 24, 2020
9865d87
Revert "remove test case filter in runtime test"
sebastienlagarde Oct 24, 2020
a1dd1a9
Revert "Restored purge of unused resources in render graph (#2306)"
sebastienlagarde Oct 24, 2020
31970e6
Update documentation
sebastienlagarde Oct 24, 2020
1d70c8b
Revert: Fix nan when decal affect normals (#2319)
sebastienlagarde Oct 24, 2020
58a3a07
Merge branch 'hd/bugfix' into HDRP/avoid-errors-if-user-define-null-p…
sebastienlagarde Oct 24, 2020
3fc7c42
Merge branch 'master' into HDRP/avoid-errors-if-user-define-null-para…
sebastienlagarde Oct 26, 2020
5e2a440
Update CoreEditorUtils.cs
sebastienlagarde Oct 26, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions com.unity.render-pipelines.core/Runtime/Volume/VolumeComponent.cs
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,12 @@ protected virtual void OnEnable()
.AsReadOnly();

foreach (var parameter in parameters)
parameter.OnEnable();
{
if(parameter != null)
parameter.OnEnable();
else
Debug.LogWarning("Volume Component " + GetType().Name + " contains a null parameter; please make sure all parameters are initialized to a default value. Until this is fixed the null parameters will not be considered by the system.");
}
}

/// <summary>
Expand All @@ -108,7 +113,10 @@ protected virtual void OnDisable()
return;

foreach (var parameter in parameters)
parameter.OnDisable();
{
if (parameter != null)
parameter.OnDisable();
}
}
/// <summary>
/// Interpolates a <see cref="VolumeComponent"/> with this component by an interpolation
Expand Down Expand Up @@ -222,7 +230,10 @@ public override int GetHashCode()
public void Release()
{
for (int i = 0; i < parameters.Count; i++)
parameters[i].Release();
{
if(parameters[i] != null)
parameters[i].Release();
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -227,8 +227,11 @@ void ReplaceData(VolumeStack stack, List<VolumeComponent> components)

for (int i = 0; i < count; i++)
{
target.parameters[i].overrideState = false;
target.parameters[i].SetValue(component.parameters[i]);
if(target.parameters[i] != null)
{
target.parameters[i].overrideState = false;
target.parameters[i].SetValue(component.parameters[i]);
}
}
}
}
Expand Down
3 changes: 2 additions & 1 deletion com.unity.render-pipelines.high-definition/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Changelog
# Changelog
All notable changes to this package will be documented in this file.

The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
Expand Down Expand Up @@ -48,6 +48,7 @@ The version number for this package has increased due to a version update of a r
- Fixed the ray tracing shadow UI being displayed while it shouldn't (case 1286391).
- Fixed issues with physically-based DoF, improved speed and robustness
- Fixed a warning happening when putting the range of lights to 0.
- Fixed issue when null parameters in a volume component would spam null reference errors. Produce a warning instead.

### Changed
- Combined occlusion meshes into one to reduce draw calls and state changes with XR single-pass.
Expand Down