Skip to content

Restored default directional light intensity constant #2345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2020
Merged

Restored default directional light intensity constant #2345

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions com.unity.render-pipelines.high-definition/Runtime/Lighting/Light/HDAdditionalLightData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public static BoolScalableSetting UseContactShadow(HDRenderPipelineAsset hdrp) =
/// <summary>
/// The default intensity value for directional lights in Lux
/// </summary>
public const float k_DefaultDirectionalLightIntensity = 100000; // In lux
public const float k_DefaultDirectionalLightIntensity = Mathf.PI; // In lux
/// <summary>
/// The default intensity value for punctual lights in Lumen
/// </summary>
Expand Down Expand Up @@ -1986,7 +1986,7 @@ internal void ReserveShadowMap(Camera camera, HDShadowManager shadowManager, HDS
// ease out and invert the curve, give more importance to closer distances
distance01 = 1.0f - Mathf.Pow(distance01, 2);

// normalized ratio between light range and distance
// normalized ratio between light range and distance
float range01 = Mathf.Clamp01(visibleLight.range / Vector3.Distance(camera.transform.position, visibleLight.GetPosition()));

float scaleFactor01 = Mathf.Max(distance01, range01);
Expand Down Expand Up @@ -2611,7 +2611,7 @@ public static void InitDefaultHDAdditionalLightData(HDAdditionalLightData lightD
{
case HDLightType.Directional:
lightData.lightUnit = LightUnit.Lux;
lightData.intensity = k_DefaultDirectionalLightIntensity;
lightData.intensity = k_DefaultDirectionalLightIntensity / Mathf.PI * 100000.0f; // Change back to just k_DefaultDirectionalLightIntensity on 11.0.0 (can't change constant as it's a breaking change)
break;
case HDLightType.Area: // Rectangle by default when light is created
switch (lightData.areaLightShape)
Expand Down