Hdrp/update decal handles fix #2402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RSlysz
requested review from
a team,
JordanL8,
JulienIgnace-Unity and
sebastienlagarde
JulienIgnace-Unity
approved these changes
Oct 27, 2020
JordanL8
approved these changes
Oct 27, 2020
JordanL8
reviewed
Oct 27, 2020
| | **Property** | **Description** | | ||
| | ----------------------- | ------------------------------------------------------------ | | ||
| | **Size** | The 3D size of the projector influence box, and thus the decal. The projector scales the decal to match the **X** and **Z** components of the **Size**. The Decal Projector component projects decals along the local y-axis. | | ||
| | **Size** | The 3D size of the projector influence box, and thus the decal along the projected plane. The projector scales the decal to match the **Width** (along local X-axis) and **Height** (along local Y-axis) components of the **Size**. | |
There was a problem hiding this comment.
The 3D size of the projector influence box, and thus the decal along the projected plane. The projector scales the decal to match the Width (along the local x-axis) and Height (along the local y-axis) components of the Size.
There was a problem hiding this comment.
@JordanL8 Just realized that thus it is not a 3D size but only 2D. I propose to just remove the "3D"
JordanL8
reviewed
Oct 27, 2020
| | ----------------------- | ------------------------------------------------------------ | | ||
| | **Size** | The 3D size of the projector influence box, and thus the decal. The projector scales the decal to match the **X** and **Z** components of the **Size**. The Decal Projector component projects decals along the local y-axis. | | ||
| | **Size** | The 3D size of the projector influence box, and thus the decal along the projected plane. The projector scales the decal to match the **Width** (along local X-axis) and **Height** (along local Y-axis) components of the **Size**. | | ||
| | **Projection Depth** | The depth of the projector influence box. The projector scales the decal to match **Projection Depth**. The Decal Projector component projects decals along the local Z-axis. | |
sebastienlagarde
approved these changes
Oct 27, 2020
|
Merging the fix for the 10.2 release |
sebastienlagarde
added a commit
that referenced
this pull request
Oct 29, 2020
* fix issue on dragging handle * Update documentation * Fix multiline issue with small sized inspector window * Fix DecalProjector editor flickering while resizing Inspector window * Side fix DensityVolume error on selection * Update CHANGELOG.md * Update Decal-Projector.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
sebastienlagarde
added a commit
that referenced
this pull request
Oct 30, 2020
This reverts commit 5f3be78.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Update the documentation with change from PR #2316
Small fixes:
Side small fix:
Testing status
Manual tested the dragger on the label work again.
Manually tested resizing the inspector window.
Comments to reviewers
Other issue found in Smoke test about the gizmo flickering. It is not localized only on the DecalProjector but also occures on the DensityVolume. In seams to be an issue related with the [DrawGizmo] attribute as if you comment every single line of logic but let the attribute, you still have the flickering ( https://docs.google.com/document/d/1Uo62Zcamck3MXQaZzflCeeQUewjO-x7GlpdDYeMVCKY/edit#heading=h.6lp97agrumda ). Cannot investigate deeper on it. But seams to be a more global issue.