Skip to content

Conversation

johnpars
Copy link
Contributor

Purpose of this PR

Another small PR, similar in vain to #2398, except it intends to propagate the label/checkbox indentation for all HDRP Volume Components (The previous PR only did this for Volume Components with Quality; now all indentation for Volumes should be a similar convention). This means it will update the following:

  • Pathtracing
  • Recursive Rendering
  • Subsurface Scattering
  • Shadows
  • Sky (Gradient, HDRP, Physically Based)

image


Comments to reviewers

~

@johnpars johnpars requested review from a team and sebastienlagarde October 28, 2020 19:18
@github-actions github-actions bot added the HDRP label Oct 28, 2020
@sebastienlagarde sebastienlagarde requested review from a team and iM0ve and removed request for a team October 28, 2020 21:48
@johnpars johnpars marked this pull request as ready for review October 29, 2020 18:56
@johnpars johnpars marked this pull request as draft October 29, 2020 19:00
@johnpars
Copy link
Contributor Author

@sebastienlagarde sebastienlagarde removed the request for review from iM0ve October 29, 2020 20:25
@sebastienlagarde
Copy link
Contributor

Merging for package 10.2

@sebastienlagarde sebastienlagarde marked this pull request as ready for review October 29, 2020 20:25
@sebastienlagarde sebastienlagarde merged commit 2964dc6 into master Oct 29, 2020
@sebastienlagarde sebastienlagarde deleted the HDRP/add-more-volume-component-indentation branch October 29, 2020 20:26
sebastienlagarde pushed a commit that referenced this pull request Oct 29, 2020
sebastienlagarde added a commit that referenced this pull request Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants