Improvement to the ray traced reflection denoising #2798
Conversation
|
@JordanL8 FYI |
|
[Not finished testing]
|
There was a problem hiding this comment.
Tried multiple scene from out Full Test pass project with different reflective setup with different smoothness transitions. ✔️
Tested with different viewport size with scene and game view, deferred and forward. ✔️
Took a look at the updated doc ✔️
Also tested RTGI in perf (because part of denoiser is shared) and difference is very subtle but can be seen as "better" but definitely not worse. ✔️
See comment above to also remove upscale radius in the RTGI also to match what is done with SSR in perf. ❗
Couldn't find a case/setup where the PR is worse than what was previously done.
Biggest improvement can be seen using half resolution in performance mode.
Checkbox that force to affect perfectly smooth surface definitely helps reducing aliasing and small glitches that attracts the eye ✔️
Example of improvement at half resolution (Left is before / right is after)
|
|
||
| #endregion | ||
|
|
||
| #region Legacy Pipeline |
There was a problem hiding this comment.
What is "Legacy pipeline"?
There was a problem hiding this comment.
this pr took too much time to get merged. @JulienIgnace-Unity removed this part of the code i think
|
|
||
| GGXSample GenerateGGXSampleDirection(uint2 currentCoord, float3 normalWS, float3 viewWS, float roughness, int frameIndex) | ||
| { | ||
| // Create the local ortho basis |
There was a problem hiding this comment.
is this function really specialise to this files? Shouldn't this be share.
There was a problem hiding this comment.
This exact version is only used for perf rtr
…ray traced reflection denoising. - Fixed issues in geometry buffer reading for half res RTR and RTGI. - Removed the upscale radius from the RTR. - How the history validity is properly tracked for RTR. - Changed the denoising strategy for very rough RTR surfaces. - Updated tooltip and removed documentation for a property that no longer exists - Added informatiom about the Affects Smooth Surfaces property
anisunity
force-pushed
the
HDRP/rtr-improvements-hr
branch
from
623e68a to
d880e69
Compare
|
Merging and updating screenshots |
4 participants
Testing status
Tested on various scenes
Ran the tests locally
This PR needs to be tested quite extensively before being merged. I already discussed what needs to be tested with @remi-chapelain .